fix: network filtered view crash

[tommasini]

Description

Network list filtered view crash when removing the network on the redux state on the add network view and then it's navigating back to the screen, but the list is not updated

This needs to be fixed to move forward with E2E work

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

https://recordit.co/O3haA4sCxZ

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 17d36c8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5d53561b-89cc-4fd6-888f-ecd3b2f4a7ac

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 41.61%. Comparing base (d669eb3) to head (17d36c8).

Files	Patch %	Lines
...omponents/Views/Settings/NetworksSettings/index.js	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8846      +/-   ##
==========================================
- Coverage   41.61%   41.61%   -0.01%     
==========================================
  Files        1269     1269              
  Lines       30869    30871       +2     
  Branches     3086     3086              
==========================================
  Hits        12846    12846              
- Misses      17246    17248       +2     
  Partials      777      777              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[cortisiko]

Looks good!

[MarioAslau]

Looks good!