Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Gas Fee Controller minor update to version 6.1.0 #8850

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Mar 5, 2024

Description

This is a minor update to gas fee controller update

ts-expect-error added on the onNetworkStateChange of gas-fee-controller, since does not use the ticker property on this method it isn't blocked by the network controller update to v11

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Sepolia and Linea goerli testnet transactions: https://recordit.co/J3ESQ8hxkR

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform labels Mar 5, 2024
@tommasini tommasini requested a review from a team as a code owner March 5, 2024 16:11
Copy link
Contributor

github-actions bot commented Mar 5, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 5, 2024
Copy link
Contributor

github-actions bot commented Mar 5, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0c45bf0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/507aa159-657b-4170-9bf2-0016d590899a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

socket-security bot commented Mar 5, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/gas-fee-controller@6.1.0 Transitive: environment, filesystem, network +94 17.3 MB metamaskbot

🚮 Removed packages: npm/@metamask/gas-fee-controller@6.0.0

View full report↗︎

Copy link

socket-security bot commented Mar 5, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

jpcloureiro
jpcloureiro previously approved these changes Mar 5, 2024
tommasini and others added 2 commits March 5, 2024 21:26
… network state change , it needs network controller to be updated but it is not a blocker for this update
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.61%. Comparing base (0c45fbf) to head (d75a87d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8850   +/-   ##
=======================================
  Coverage   41.61%   41.61%           
=======================================
  Files        1269     1269           
  Lines       30871    30871           
  Branches     3086     3086           
=======================================
  Hits        12846    12846           
  Misses      17248    17248           
  Partials      777      777           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@jpcloureiro jpcloureiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ✅

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini merged commit 6abafb6 into main Mar 6, 2024
30 of 31 checks passed
@tommasini tommasini deleted the update/1580-gas-fee-controller-update-6.1.0 branch March 6, 2024 20:58
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 6, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.19.0 Issue or pull request that will be included in release 7.19.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants