Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: E2E networks Flow #8856

Merged
merged 29 commits into from
Apr 23, 2024
Merged

test: E2E networks Flow #8856

merged 29 commits into from
Apr 23, 2024

Conversation

cortisiko
Copy link
Member

@cortisiko cortisiko commented Mar 6, 2024 •
edited

Description

The goal of this task is to enhance our critical flow end-to-end (e2e) test coverage by improving our networks e2e tests coverage in our existing test suite. By doing so, we aim to improve our overall test coverage. This ticket will focus on deleting a popular network.

Related issues

Fixes:
https://github.com/MetaMask/mobile-planning/issues/1546

https://github.com/MetaMask/mobile-planning/issues/1506

Manual testing steps

N/A because this is an E2E test

Screenshots/Recordings

Regression run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0c46dca5-49aa-4670-88d7-61b2d7f06ee5

Smoke run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/66ff1cba-fff1-4ade-9503-2266b94e59d4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.77%. Comparing base (82a4668) to head (75632a1).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8856   +/-   ##
=======================================
  Coverage   43.77%   43.77%           
=======================================
  Files        1274     1274           
  Lines       31126    31126           
  Branches     3168     3168           
=======================================
  Hits        13624    13624           
  Misses      16689    16689           
  Partials      813      813

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cortisiko cortisiko self-assigned this Mar 28, 2024
@cortisiko cortisiko added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7efc9d2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a9b5a598-f41b-4d51-9a3b-de6879504845

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko added team-mobile-platform No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. labels Apr 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 18, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e1dc661
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/73a6902b-2832-4f88-8428-79dddc81bf87

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 19, 2024
@cortisiko cortisiko marked this pull request as ready for review April 19, 2024 00:55
@cortisiko cortisiko requested a review from a team as a code owner April 19, 2024 00:55
@cortisiko cortisiko changed the title test: E2E search network test: E2E networks Flow Apr 19, 2024
@cortisiko cortisiko added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 19, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2510683
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7d769517-21af-44b0-b85c-2dc81b569a40

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 79075ee
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e11b1149-c896-4201-8874-aeef764285f5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9f5f648
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b97c8f3e-5cef-4bb0-b670-fa3a62d26abc

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

tommasini
tommasini approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM!

SamuelSalas
SamuelSalas approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@SamuelSalas SamuelSalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko merged commit 070db69 into main Apr 23, 2024
37 checks passed
@cortisiko cortisiko deleted the detox/search-network branch April 23, 2024 23:48
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
@gauthierpetetin gauthierpetetin added release-7.22.0 Issue or pull request that will be included in release 7.22.0 and removed release-7.28.0 labels Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SamuelSalas SamuelSalas SamuelSalas approved these changes

@tommasini tommasini tommasini approved these changes

Assignees

@cortisiko cortisiko

Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.22.0 Issue or pull request that will be included in release 7.22.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cortisiko @codecov-commenter @SamuelSalas @tommasini @gauthierpetetin @metamaskbot