Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add env vars mapping in build script #8859

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

NicolasMassart
Copy link
Contributor

@NicolasMassart NicolasMassart commented Mar 6, 2024

Description

  • add env vars mapping in build script
  • add calls to qa and release steps
  • update flask function

For QA, envs are suffixed by the Segment source suffix: for QA by QA, for release by PROD and for flask by FLASK.
example: SEGMENT_WRITE_KEY_QA remaps to the app SEGMENT_WRITE_KEY

Related issues

Fixes #8769

Manual testing steps

  1. Go to bitrise QA build
  2. Run the built dapp and check that events are landing on the correct source (use Segment source debugger)

Screenshots/Recordings

NA

Before

NA

After

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

add calls to qa and release steps
update flask function
Copy link
Contributor

github-actions bot commented Mar 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@NicolasMassart NicolasMassart marked this pull request as ready for review March 6, 2024 13:01
@NicolasMassart NicolasMassart requested a review from a team as a code owner March 6, 2024 13:01
@NicolasMassart NicolasMassart added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No E2E Smoke Needed If the PR does not need E2E smoke test run labels Mar 6, 2024
@github-actions github-actions bot added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 6, 2024
Copy link
Contributor

github-actions bot commented Mar 6, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 53cc46e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a6e1948a-b1b6-4013-94b5-a1e756960c54

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NicolasMassart NicolasMassart merged commit aa8536e into main Mar 6, 2024
48 of 50 checks passed
@NicolasMassart NicolasMassart deleted the 8769_bitrise_segment_env branch March 6, 2024 17:26
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 6, 2024
@metamaskbot metamaskbot added release-7.19.0 Issue or pull request that will be included in release 7.19.0 release-7.18.0 Issue or pull request that will be included in release 7.18.0 and removed release-7.19.0 Issue or pull request that will be included in release 7.19.0 labels Mar 6, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-7.18.0 on PR. Adding release label release-7.18.0 on PR and removing other release labels(release-7.19.0), as PR was cherry-picked in branch 7.18.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run release-7.18.0 Issue or pull request that will be included in release 7.18.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

feat: allow different values depending on environment for Segment config
5 participants