Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type for auth events and typo #8861

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

NicolasMassart
Copy link
Contributor

@NicolasMassart NicolasMassart commented Mar 6, 2024

Description

  • type for auth events
  • fix typo

Related issues

Fixes #8860

Manual testing steps

  • Run the app, and enter password to login.
  • Check Segment debugger:
    the identify event should be like the following with "Authentication Type": "password",:
    {
      "context": {
       ...
      },
      ...
      "traits": {
        ...
        "Authentication Type": "password",
      },
      "type": "identify",
      "userId": "**** REDACTED UUID****",
      "writeKey": "REDACTED"
    }
    instead of "[object Object]": "password":
    {
      "context": {
       ...
      },
      ...
      "traits": {
        ...
        "[object Object]": "password"
      },
      "type": "identify",
      "userId": "**** REDACTED UUID****",
      "writeKey": "REDACTED"
    }

Screenshots/Recordings

NA

Before

before

After

after

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NicolasMassart NicolasMassart self-assigned this Mar 6, 2024
Copy link
Contributor

github-actions bot commented Mar 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@NicolasMassart NicolasMassart added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform needs-smoke-e2e labels Mar 6, 2024
@NicolasMassart NicolasMassart marked this pull request as ready for review March 6, 2024 13:44
@NicolasMassart NicolasMassart requested a review from a team as a code owner March 6, 2024 13:44
@github-actions github-actions bot added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 6, 2024
Copy link
Contributor

github-actions bot commented Mar 6, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5255cba
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1d36102f-4e5f-4a56-b2a0-7e44955143c9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@NicolasMassart NicolasMassart added release-7.18.0 Issue or pull request that will be included in release 7.18.0 release-blocker This bug is blocking the next release and removed release-blocker This bug is blocking the next release labels Mar 7, 2024
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NicolasMassart NicolasMassart added needs-qa Any New Features that needs a full manual QA prior to being added to a release. Run Smoke E2E Triggers smoke e2e on Bitrise and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 7, 2024
@Cal-L
Copy link
Contributor

Cal-L commented Mar 7, 2024

Could you provide a screenshot in Segment, I don't think we have access yet

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NicolasMassart NicolasMassart added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 7, 2024
@NicolasMassart NicolasMassart merged commit c02483c into main Mar 7, 2024
74 of 85 checks passed
@NicolasMassart NicolasMassart deleted the 8860_fix_auth_event_props branch March 7, 2024 21:01
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2024
@metamaskbot metamaskbot added release-7.19.0 Issue or pull request that will be included in release 7.19.0 and removed release-7.19.0 Issue or pull request that will be included in release 7.19.0 labels Mar 7, 2024
@metamaskbot
Copy link
Collaborator

More than one release label on PR. Keeping the lowest one (release-7.18.0) on PR and removing other release labels (release-7.19.0).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-smoke-e2e No QA Needed Apply this label when your PR does not need any QA effort. release-7.18.0 Issue or pull request that will be included in release 7.18.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

fix: Wrong authentication property key for Segment event in app/core/SecureKeychain.js
4 participants