Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Run all tests on release e2e pipeline #8872

Merged
merged 3 commits into from
Mar 6, 2024
Merged

ci: Run all tests on release e2e pipeline #8872

merged 3 commits into from
Mar 6, 2024

Conversation

cortisiko
Copy link
Member

@cortisiko cortisiko commented Mar 6, 2024 •
edited

Description

Enabling all tests to run on the release E2E pipeline.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1ac3ba50-5bb7-4d7a-a9a4-5f2863ca5f04

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.63%. Comparing base (27c9362) to head (13ee9dc).
Report is 15 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8872      +/-   ##
==========================================
+ Coverage   41.61%   41.63%   +0.01%     
==========================================
  Files        1269     1270       +1     
  Lines       30869    30887      +18     
  Branches     3086     3083       -3     
==========================================
+ Hits        12847    12860      +13     
- Misses      17245    17249       +4     
- Partials      777      778       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cortisiko cortisiko marked this pull request as ready for review March 6, 2024 22:10
@cortisiko cortisiko requested a review from a team as a code owner March 6, 2024 22:10
@github-actions github-actions bot added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 13ee9dc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9753003c-829a-40e3-9dce-42836d03b8ab

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. team-mobile-platform labels Mar 6, 2024
@Cal-L Cal-L changed the title Ci: Run all tests on release e2e pipeline ci: Run all tests on release e2e pipeline Mar 6, 2024
Cal-L
Cal-L approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chrisleewilcox
chrisleewilcox approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko merged commit 72d339e into main Mar 6, 2024
37 of 42 checks passed
@cortisiko cortisiko deleted the ci/run-all-tests-on-release-e2e-pipeline branch March 6, 2024 22:35
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.19.0 Issue or pull request that will be included in release 7.19.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cortisiko @codecov-commenter @chrisleewilcox @Cal-L @metamaskbot