-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: patch for assets controller v11.0.1 #8881
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/assets-controllers@10.0.0 |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8881 +/- ##
=======================================
Coverage 43.27% 43.27%
=======================================
Files 1271 1271
Lines 30916 30916
Branches 3092 3092
=======================================
Hits 13378 13378
Misses 16765 16765
Partials 773 773 ☔ View full report in Codecov by Sentry. |
|
… will not have an issue since we are only deprecating the eth-query on this version of assets-controler
… was removed on this version
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx @tommasini for reviewing this with me and updating the script
lgtm after running the script in this branch and noting no changes
and also after checking https://github.com/MetaMask/core/tree/patch/mobile-assets-controllers-v-11-0-1 and running yarn build
and checking dist
folders
Description
Update to assets controller version 11.0.1
TokenRatesController
that we already had on our repoCheck more easily the diff on this core branch:
patch/mobile-assets-controllers-v-11-0-1
This PR removes a unnecessary resolution since, the package babel-runtime was removed from assets-controllers on version 11.0.0
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Import tokens: https://recordit.co/fLGuFr20AH
import NFts: https://recordit.co/GlDRhQoIfp
Optimism send transaction and import tokens: https://recordit.co/RHtJ7y0jxB
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist