-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix wallet_addEthereumChain
rpcUrls trailing slash cleanup
#8882
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
wallet_addEthereumChain
rpcUrls trailing slash ReDoswallet_addEthereumChain
rpcUrls trailing slash ReDos
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8882 +/- ##
=======================================
Coverage 43.24% 43.24%
=======================================
Files 1271 1271
Lines 30913 30913
Branches 3090 3090
=======================================
Hits 13369 13369
Misses 16769 16769
Partials 775 775 ☔ View full report in Codecov by Sentry. |
wallet_addEthereumChain
rpcUrls trailing slash ReDoswallet_addEthereumChain
rpcUrls trailing slash cleanup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
Quality Gate passedIssues Measures |
Description
This PR improves the the
wallet_addEthereumChain
rpcUrls trailing slash cleanupRelated issues
fixes https://github.com/MetaMask/mobile-planning/issues/1589
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist