Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix wallet_addEthereumChain rpcUrls trailing slash cleanup #8882

Merged
merged 6 commits into from
Mar 12, 2024

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Mar 8, 2024

Description

This PR improves the the wallet_addEthereumChain rpcUrls trailing slash cleanup

Related issues

fixes https://github.com/MetaMask/mobile-planning/issues/1589

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jiexi jiexi requested a review from a team as a code owner March 8, 2024 00:19
Copy link
Contributor

github-actions bot commented Mar 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jiexi jiexi changed the title Fix wallet_addEthereumChain rpcUrls trailing slash ReDos fix: Fix wallet_addEthereumChain rpcUrls trailing slash ReDos Mar 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.24%. Comparing base (d47b4ab) to head (c3e16e9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8882   +/-   ##
=======================================
  Coverage   43.24%   43.24%           
=======================================
  Files        1271     1271           
  Lines       30913    30913           
  Branches     3090     3090           
=======================================
  Hits        13369    13369           
  Misses      16769    16769           
  Partials      775      775           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiexi jiexi changed the title fix: Fix wallet_addEthereumChain rpcUrls trailing slash ReDos fix: Fix wallet_addEthereumChain rpcUrls trailing slash cleanup Mar 8, 2024
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

Copy link

sonarcloud bot commented Mar 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jiexi jiexi merged commit 4c2d683 into main Mar 12, 2024
29 checks passed
@jiexi jiexi deleted the jl/mp-1589/fix-wallet_addEthereumChain-redos branch March 12, 2024 17:45
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.19.0 Issue or pull request that will be included in release 7.19.0 team-wallet-api-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants