Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ramp): loading fox position #8906

Merged
merged 1 commit into from
Mar 13, 2024
Merged

fix(ramp): loading fox position #8906

merged 1 commit into from
Mar 13, 2024

Conversation

wachunei
Copy link
Member

Description

The initial loading animation of the fox face must be centered. This PR fixes the position in bigger screens.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/RAMPS-1428

Manual testing steps

  1. Go through Buy or Sell flow
  2. Get quotes
  3. Fox animation must be centered

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features labels Mar 12, 2024
Copy link

sonarcloud bot commented Mar 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wachunei wachunei marked this pull request as ready for review March 12, 2024 14:47
@wachunei wachunei requested a review from a team as a code owner March 12, 2024 14:47
@github-actions github-actions bot added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 12, 2024
Copy link
Contributor

github-actions bot commented Mar 12, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 033892b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6b16d38a-c011-4700-8d0f-1d3d5809e162

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 13, 2024
@wachunei wachunei merged commit bdba039 into main Mar 13, 2024
43 checks passed
@wachunei wachunei deleted the fix/ramp-loading-fox branch March 13, 2024 15:22
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.19.0 Issue or pull request that will be included in release 7.19.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-ramp issues related to Ramp features
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants