Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Include env variable copying into yarn setup command #8919

Merged
merged 7 commits into from
Mar 18, 2024

Conversation

kylanhurt
Copy link
Contributor

Description

This task is an update to the on-boarding process, helping streamline the creation of environment variables.

Related issues

Works on: https://github.com/MetaMask/mobile-planning/issues/1465

Manual testing steps

  1. Delete (or change the file name) of .ios.env, .android.env, and .js.env files. Then run yarn setup and see if new files are created with default values.

Screenshots/Recordings

env-variables-screen-capture-edit-1.mp4

Before

Before you had to manually use a cp ... command, now it is included in yarn setup if the files do not already exist

After

Now the yarn setup command generates the .env files. See earlier screen recording.

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@kylanhurt kylanhurt added team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 13, 2024
Copy link
Contributor

github-actions bot commented Mar 13, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6fb862e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b860fc8e-a579-4040-86ed-79696538453c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.26%. Comparing base (e63269f) to head (bee455f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8919   +/-   ##
=======================================
  Coverage   43.26%   43.26%           
=======================================
  Files        1271     1271           
  Lines       30920    30920           
  Branches     3092     3092           
=======================================
  Hits        13379    13379           
  Misses      16769    16769           
  Partials      772      772           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kylanhurt kylanhurt marked this pull request as ready for review March 14, 2024 15:14
@kylanhurt kylanhurt requested a review from a team as a code owner March 14, 2024 15:14
Copy link
Contributor

github-actions bot commented Mar 14, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: bee455f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/09d49a53-6344-4892-866b-884213c39af3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@kylanhurt kylanhurt added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 14, 2024
jpcloureiro
jpcloureiro previously approved these changes Mar 14, 2024
Copy link
Contributor

@jpcloureiro jpcloureiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Great addition Kylan 👍

ios/Podfile.lock Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@kylanhurt kylanhurt merged commit f88bc83 into main Mar 18, 2024
29 of 30 checks passed
@kylanhurt kylanhurt deleted the kylan/readme-improvements branch March 18, 2024 14:07
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 18, 2024
@kylanhurt kylanhurt restored the kylan/readme-improvements branch March 20, 2024 19:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.19.0 Issue or pull request that will be included in release 7.19.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants