-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Include env variable copying into yarn setup command #8919
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8919 +/- ##
=======================================
Coverage 43.26% 43.26%
=======================================
Files 1271 1271
Lines 30920 30920
Branches 3092 3092
=======================================
Hits 13379 13379
Misses 16769 16769
Partials 772 772 ☔ View full report in Codecov by Sentry. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Great addition Kylan 👍
8f9dd5c
|
Description
This task is an update to the on-boarding process, helping streamline the creation of environment variables.
Related issues
Works on: https://github.com/MetaMask/mobile-planning/issues/1465
Manual testing steps
.ios.env
,.android.env
, and.js.env
files. Then runyarn setup
and see if new files are created with default values.Screenshots/Recordings
env-variables-screen-capture-edit-1.mp4
Before
Before you had to manually use a
cp ...
command, now it is included inyarn setup
if the files do not already existAfter
Now the
yarn setup
command generates the.env
files. See earlier screen recording.Pre-merge author checklist
Pre-merge reviewer checklist