Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: yarn version updated to 1.22.22 #8921

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Mar 13, 2024

Description

Yarn version was updated to 1.22.22 and we were impacted, on this PR we update yarn version on bitrise to be the same as on the github action for consistency and we solve duplicated issues on our lockfile

yarn was updated to fix a bug, more details here

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…we update yarn version on bitrise to be the same as on the github action for consistency and we solve duplicated issues on our lockfile
@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-wallet-framework team-mobile-platform labels Mar 13, 2024
@tommasini tommasini requested a review from a team as a code owner March 13, 2024 19:32
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Mar 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini merged commit 3edd7a3 into main Mar 13, 2024
43 checks passed
@tommasini tommasini deleted the fix/yarn-version-updated-1.22.22 branch March 13, 2024 20:38
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 13, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.19.0 Issue or pull request that will be included in release 7.19.0 team-mobile-platform team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants