-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: crash during pairing request from Ledger #8936
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/react-native-ble-plx@3.1.1 |
Bitrise✅✅✅ Commit hash: c1c7464 Note
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8936 +/- ##
=======================================
Coverage 43.74% 43.74%
=======================================
Files 1273 1273
Lines 31103 31103
Branches 3161 3161
=======================================
Hits 13606 13606
Misses 16684 16684
Partials 813 813 ☔ View full report in Codecov by Sentry. |
Bitrise✅✅✅ Commit hash: 7223d8d Note
|
Bitrise✅✅✅ Commit hash: 01cee36 Note
|
Smoke e2e tests pass #8936 |
Quality Gate passedIssues Measures |
Fix working as expected, testing on Samsung Android 13: Screen_Recording_20240318_113312_MetaMask-QA.mp4 |
Description
This PR fix the #8641 which cause metamask app crash when user reject pair issue request in ledger in android.
upgrade
react-native-ble-plx
library to latest version which contain the fix for android bluetooth disconnected exception not caught in native code.Related issues
Fixes: #8641
Manual testing steps
retry
button will appearretry
, this time, we confirmpair
in both ledger and MM mobile screen.On second attempt, note MetaMask keeps stopping
Screenshots/Recordings
Before
https://recordit.co/Y4JaFbIsEe
After
Screen_Recording_20240307_162751_MetaMask.mp4
Pre-merge author checklist
Pre-merge reviewer checklist