-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: circular dependency on MetaMetrics configure #8937
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8937 +/- ##
==========================================
- Coverage 43.26% 43.26% -0.01%
==========================================
Files 1271 1271
Lines 30920 30921 +1
Branches 3092 3092
==========================================
Hits 13379 13379
Misses 16769 16769
- Partials 772 773 +1 ☔ View full report in Codecov by Sentry. |
prevent circular dependency issue
cc93096
to
0807147
Compare
Quality Gate passedIssues Measures |
Bitrise✅✅✅ Commit hash: 0807147 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Description
Move identify call out for metametrics to prevent circular dependency issue.
Call it just after the app index metametrics configuration.
Related issues
Fixes: issue introduced in #8888
Manual testing steps
NA
Screenshots/Recordings
NA
Before
NA
After
NA
Pre-merge author checklist
Pre-merge reviewer checklist