Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: circular dependency on MetaMetrics configure #8937

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

NicolasMassart
Copy link
Contributor

@NicolasMassart NicolasMassart commented Mar 14, 2024

Description

Move identify call out for metametrics to prevent circular dependency issue.
Call it just after the app index metametrics configuration.

Related issues

Fixes: issue introduced in #8888

Manual testing steps

NA

Screenshots/Recordings

NA

Before

NA

After

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 43.26%. Comparing base (e63269f) to head (0807147).

Files Patch % Lines
app/components/Nav/App/index.js 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8937      +/-   ##
==========================================
- Coverage   43.26%   43.26%   -0.01%     
==========================================
  Files        1271     1271              
  Lines       30920    30921       +1     
  Branches     3092     3092              
==========================================
  Hits        13379    13379              
  Misses      16769    16769              
- Partials      772      773       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

prevent circular dependency issue
@NicolasMassart NicolasMassart force-pushed the fix/8888_metametrics_circular_dep branch from cc93096 to 0807147 Compare March 14, 2024 15:21
@MetaMask MetaMask deleted a comment from sonarcloud bot Mar 14, 2024
Copy link

sonarcloud bot commented Mar 14, 2024

@NicolasMassart NicolasMassart marked this pull request as ready for review March 14, 2024 15:34
@NicolasMassart NicolasMassart requested a review from a team as a code owner March 14, 2024 15:34
@github-actions github-actions bot added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 14, 2024
Copy link
Contributor

github-actions bot commented Mar 14, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0807147
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/11d44a7a-142a-4573-8565-31ab2fd6b9b0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@NicolasMassart NicolasMassart merged commit 2c0d6ce into main Mar 14, 2024
35 checks passed
@NicolasMassart NicolasMassart deleted the fix/8888_metametrics_circular_dep branch March 14, 2024 16:37
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.19.0 Issue or pull request that will be included in release 7.19.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants