feat: Network Controller update to v12.1.2 #8952

tommasini · 2024-03-15T11:05:36Z

Description

Update network controller to version 12.1.2
re-applied the patch
created a migration to clean the storage of networkDetails and networkStatus properties of NetworkController that were deprecated
removed ts-expect-error from engine from controllers that were expecting network controller v12
update selectors that were dependents of the deprecated properties

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/1555

Manual testing steps

Go to this page...

Screenshots/Recordings

Add/remove/switch networks: https://recordit.co/LQvO3ZAtkQ

Before migrations and network controller update:
https://recordit.co/KwkE7QUjl6

After migrations and network controller update:
https://recordit.co/Bl1BkZVK1F

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…eated a migration to clean the storage of networkDetails and networkStatus properties of NetworkController that were deprecated, removed ts-expect-error from engine from controllers that were expecting network controller v12, update selectors that were dependents of the deprecated properties

github-actions · 2024-03-15T11:05:47Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-03-15T11:10:13Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/network-controller@12.1.2	environment Transitive: filesystem, network	`+100`	17.4 MB	metamaskbot

View full report↗︎

…rties of network controller

…update 024 migrations unit tests

github-actions · 2024-03-18T18:48:18Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0bbc3cf
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5626944f-6a37-40b4-be2a-b0d4fe1995a0

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-03-18T18:55:39Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2e48c29
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f4d20e6f-dd73-45f0-8eb7-20263121528b

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-03-19T00:46:56Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ca4e7b2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fb8ba490-6232-42a4-a7f2-2804210db25f

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

codecov-commenter · 2024-03-19T00:56:14Z

Codecov Report

Attention: Patch coverage is 83.33333% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 43.83%. Comparing base (82a4668) to head (7dc104e).

Files	Patch %	Lines
app/selectors/networkController.ts	20.00%	4 Missing ⚠️
app/core/Engine.ts	0.00%	2 Missing ⚠️
app/store/migrations/036.ts	95.12%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8952      +/-   ##
==========================================
+ Coverage   43.77%   43.83%   +0.06%     
==========================================
  Files        1274     1275       +1     
  Lines       31126    31169      +43     
  Branches     3168     3182      +14     
==========================================
+ Hits        13624    13664      +40     
- Misses      16689    16690       +1     
- Partials      813      815       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-03-19T17:50:10Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7e59132
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/02a9677f-b08b-4c29-9f68-3948aaa42b03

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Cal-L

Left some comments

app/core/Engine.ts

e2e/fixtures/fixture-builder.js

app/selectors/networkController.ts

app/util/test/initial-background-state.json

app/store/migrations/024.test.js

app/store/migrations/036.ts

…al background state, adapt 36 migration to check every state data first and only then modify the data and updated the tests accordingly, updated fixture-builder with networkId property

github-actions · 2024-03-19T19:34:49Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9454fd2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/49f79317-85b1-4b61-a0da-eb70de78c20e

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-03-19T22:33:37Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7dc104e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ccf26477-5d02-47a6-b43b-5b778b69a4ff

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarcloud · 2024-03-19T22:43:17Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Cal-L

LGTM

app/util/test/initial-background-state.json

Merge branch 'main' into feat/1555-network-controllver-v12-1-2

4420902

tommasini added the team-mobile-platform label Mar 15, 2024

tommasini added 4 commits March 18, 2024 11:58

merge main and solve conflicts

a4bae5c

migraiton for selectedNetworkClientId, and networksMetadata new prope…

b517748

…rties of network controller

update unit tests on the migration 35

645911e

change fixture-builder default with new network controller data, and …

0bbc3cf

…update 024 migrations unit tests

tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 18, 2024

tommasini marked this pull request as ready for review March 18, 2024 18:48

tommasini requested a review from a team as a code owner March 18, 2024 18:48

tommasini and others added 2 commits March 18, 2024 18:51

Merge branch 'main' into feat/1555-network-controllver-v12-1-2

638893e

linea sepolia added

2e48c29

tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 18, 2024

tommasini mentioned this pull request Mar 19, 2024

feat: Update gas fee controller to version 6.1.2 #8982

Merged

13 tasks

tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 19, 2024

Merge branch 'main' into feat/1555-network-controllver-v12-1-2

ca4e7b2

tommasini requested a review from a team as a code owner March 19, 2024 00:45

tommasini added 3 commits March 19, 2024 17:44

merge main

00e59e6

re add migration for network controller update

eed5086

remove unneded change

7e59132

tommasini removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 19, 2024

tommasini added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 19, 2024

tommasini mentioned this pull request Mar 19, 2024

feat: Signature Controller v5.3.1 #8989

Merged

13 tasks

Cal-L reviewed Mar 19, 2024

View reviewed changes

address review, changed migration 024 test file for not use the initi…

9454fd2

…al background state, adapt 36 migration to check every state data first and only then modify the data and updated the tests accordingly, updated fixture-builder with networkId property

tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 19, 2024

Merge branch 'main' into feat/1555-network-controllver-v12-1-2

7dc104e

Cal-L added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 19, 2024

Cal-L approved these changes Mar 20, 2024

View reviewed changes

app/util/test/initial-background-state.json Show resolved Hide resolved

Cal-L merged commit 3ae7b3c into main Mar 20, 2024
32 of 35 checks passed

Cal-L deleted the feat/1555-network-controllver-v12-1-2 branch March 20, 2024 01:40

github-actions bot locked and limited conversation to collaborators Mar 20, 2024

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 20, 2024

metamaskbot added the release-7.20.0 Issue or pull request that will be included in release 7.20.0 label Mar 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Network Controller update to v12.1.2 #8952

feat: Network Controller update to v12.1.2 #8952

tommasini commented Mar 15, 2024 •

edited by NicolasMassart

github-actions bot commented Mar 15, 2024

socket-security bot commented Mar 15, 2024 •

edited

github-actions bot commented Mar 18, 2024 •

edited by metamaskbot

github-actions bot commented Mar 18, 2024 •

edited by metamaskbot

github-actions bot commented Mar 19, 2024 •

edited by metamaskbot

codecov-commenter commented Mar 19, 2024 •

edited

github-actions bot commented Mar 19, 2024 •

edited by metamaskbot

Cal-L left a comment

github-actions bot commented Mar 19, 2024 •

edited by metamaskbot

github-actions bot commented Mar 19, 2024 •

edited by metamaskbot

sonarcloud bot commented Mar 19, 2024

Cal-L left a comment

feat: Network Controller update to v12.1.2 #8952

feat: Network Controller update to v12.1.2 #8952

Conversation

tommasini commented Mar 15, 2024 • edited by NicolasMassart

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Mar 15, 2024

socket-security bot commented Mar 15, 2024 • edited

github-actions bot commented Mar 18, 2024 • edited by metamaskbot

Bitrise

github-actions bot commented Mar 18, 2024 • edited by metamaskbot

Bitrise

github-actions bot commented Mar 19, 2024 • edited by metamaskbot

Bitrise

codecov-commenter commented Mar 19, 2024 • edited

Codecov Report

github-actions bot commented Mar 19, 2024 • edited by metamaskbot

Bitrise

Cal-L left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 19, 2024 • edited by metamaskbot

Bitrise

github-actions bot commented Mar 19, 2024 • edited by metamaskbot

Bitrise

sonarcloud bot commented Mar 19, 2024

Quality Gate passed

Cal-L left a comment

Choose a reason for hiding this comment

tommasini commented Mar 15, 2024 •

edited by NicolasMassart

socket-security bot commented Mar 15, 2024 •

edited

github-actions bot commented Mar 18, 2024 •

edited by metamaskbot

github-actions bot commented Mar 18, 2024 •

edited by metamaskbot

github-actions bot commented Mar 19, 2024 •

edited by metamaskbot

codecov-commenter commented Mar 19, 2024 •

edited

github-actions bot commented Mar 19, 2024 •

edited by metamaskbot

github-actions bot commented Mar 19, 2024 •

edited by metamaskbot

github-actions bot commented Mar 19, 2024 •

edited by metamaskbot