Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added platform team as codeowner to component-lib, patches, bitrise.yml #8964

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Mar 15, 2024

Description

Added the Platform Team to CODEOWNER file for:

  • component-lib
  • patches
  • Ramps
  • bitrise.yml

Related issues

Fixes: NA

Manual testing steps

  1. NA

Screenshots/Recordings

NA

Before

NA

After

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.67%. Comparing base (1630a58) to head (aeb5fd5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8964   +/-   ##
=======================================
  Coverage   43.67%   43.67%           
=======================================
  Files        1271     1271           
  Lines       30921    30921           
  Branches     3092     3092           
=======================================
  Hits        13506    13506           
  Misses      16636    16636           
  Partials      779      779           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Mar 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Cal-L Cal-L merged commit 28e2325 into main Mar 18, 2024
30 checks passed
@Cal-L Cal-L deleted the chore/platform-codeowners branch March 18, 2024 20:05
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.19.0 Issue or pull request that will be included in release 7.19.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants