-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove wallet connect and sdk connect prefix from ppom domain #8977
Conversation
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8977 +/- ##
=======================================
Coverage 43.74% 43.74%
=======================================
Files 1273 1273
Lines 31104 31105 +1
Branches 3161 3161
=======================================
+ Hits 13605 13606 +1
Misses 16686 16686
Partials 813 813 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
Description
Domains from wallet connect - are being passed to ppom with a wc:: preffix (example: wc::https://furrevertoken.com/). This is causing url parsing to fail inside PPOM and needs to be fixed on MM side.
Related issues
Fixes: #2221
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist