Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove wallet connect and sdk connect prefix from ppom domain #8977

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

segun
Copy link
Contributor

@segun segun commented Mar 18, 2024

Description

Domains from wallet connect - are being passed to ppom with a wc:: preffix (example: wc::https://furrevertoken.com/). This is causing url parsing to fail inside PPOM and needs to be fixed on MM side.

Related issues

Fixes: #2221

Manual testing steps

  1. Connect to testdapp from real device
  2. Perform a malicious transaction
  3. Click Report an issue
  4. Expand the details drop down
  5. See that domain is not prefixed with wc::

Screenshots/Recordings

Before

IMG_0563

After

IMG_0564

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
@segun segun added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 18, 2024
@segun segun self-assigned this Mar 18, 2024
@segun segun requested a review from a team as a code owner March 18, 2024 18:16
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Mar 18, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.74%. Comparing base (0550041) to head (027d569).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8977   +/-   ##
=======================================
  Coverage   43.74%   43.74%           
=======================================
  Files        1273     1273           
  Lines       31104    31105    +1     
  Branches     3161     3161           
=======================================
+ Hits        13605    13606    +1     
  Misses      16686    16686           
  Partials      813      813           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@segun segun added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 18, 2024
@segun segun removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 19, 2024
Copy link

sonarcloud bot commented Mar 19, 2024

@segun segun merged commit ead4017 into main Mar 19, 2024
30 checks passed
@segun segun deleted the olu/fix-blockaid-domains-wc-sdk-connect branch March 19, 2024 15:13
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 19, 2024
@metamaskbot metamaskbot added the release-7.20.0 Issue or pull request that will be included in release 7.20.0 label Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.20.0 Issue or pull request that will be included in release 7.20.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants