Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Assets controller updated to version 12.0.0 #9007

Merged
merged 4 commits into from
Mar 20, 2024

Conversation

tommasini
Copy link
Contributor

Description

Assets controller updated to version 12.0.0, patch updated, core branch created, assets controller script updated.

Core branch: patch/mobile-assets-controllers-v-12-0-0

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

https://recordit.co/ltXhC4AwCg

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…ch created, assets controller script updated
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini marked this pull request as ready for review March 20, 2024 18:18
@tommasini tommasini requested review from a team as code owners March 20, 2024 18:18
@github-actions github-actions bot added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 20, 2024
Copy link
Contributor

github-actions bot commented Mar 20, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0947a37
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/24a172a0-87ee-4e48-93bd-8dc0b2ec8953

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you verify that Linea balances are also behaving the same outside of these changes?

@tommasini
Copy link
Contributor Author

I can confirm that it's happening on 7.17.1, and on extension, I will contact the team to know if this is a known issue

Cal-L
Cal-L previously approved these changes Mar 20, 2024
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.51%. Comparing base (d06ea4d) to head (2e11309).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9007   +/-   ##
=======================================
  Coverage   45.51%   45.51%           
=======================================
  Files        1275     1275           
  Lines       31208    31208           
  Branches     3187     3187           
=======================================
  Hits        14203    14203           
  Misses      16164    16164           
  Partials      841      841           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini merged commit 8b8d137 into main Mar 20, 2024
28 of 31 checks passed
@tommasini tommasini deleted the feat/1611-assets-controller-v12 branch March 20, 2024 20:34
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2024
@metamaskbot metamaskbot added the release-7.20.0 Issue or pull request that will be included in release 7.20.0 label Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.20.0 Issue or pull request that will be included in release 7.20.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants