Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ramp): upgrade sdk to 1.26.8 #9008

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Mar 20, 2024

Description

This PR upgrades the Ramp SDK to version 1.26.8

Changes included:

Other changes:

Related issues

Fixes:

Manual testing steps

Ramp flows must work as expected.

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features needs-ramp-qa Tickets that need feature QA on the ramps flows labels Mar 20, 2024
@wachunei wachunei requested a review from a team as a code owner March 20, 2024 14:10
Copy link

socket-security bot commented Mar 20, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@consensys/on-ramp-sdk@1.26.8 Transitive: unsafe +4 899 kB pmkowalski

🚮 Removed packages: npm/@consensys/on-ramp-sdk@1.26.2

View full report↗︎

Copy link

socket-security bot commented Mar 20, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.51%. Comparing base (04e35fb) to head (2ca8575).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9008      +/-   ##
==========================================
- Coverage   45.56%   45.51%   -0.06%     
==========================================
  Files        1275     1275              
  Lines       31169    31208      +39     
  Branches     3182     3187       +5     
==========================================
+ Hits        14202    14203       +1     
- Misses      16126    16164      +38     
  Partials      841      841              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkirb
Copy link
Contributor

bkirb commented Mar 20, 2024

@wachunei LGTM I verified Buy and Sell flows ✅

@wachunei wachunei added ramp-qa-passed and removed needs-ramp-qa Tickets that need feature QA on the ramps flows labels Mar 20, 2024
@Cal-L Cal-L added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 21, 2024
@Cal-L Cal-L added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 21, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Mar 21, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: cceeaca
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/78de7add-2e77-45bd-a8e4-c9e1dc53fc1d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 21, 2024
@wachunei wachunei merged commit 7f7636e into main Mar 21, 2024
35 checks passed
@wachunei wachunei deleted the chore/ramp-upgrade-sdk-1.26.8 branch March 21, 2024 16:53
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2024
@metamaskbot metamaskbot added the release-7.20.0 Issue or pull request that will be included in release 7.20.0 label Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ramp-qa-passed release-7.20.0 Issue or pull request that will be included in release 7.20.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-ramp issues related to Ramp features
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants