Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: isEIP1559 is undefined migration 29 issue #9013

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Mar 20, 2024

Description

Fixed migration 29 for the 7.19.0

Related issues

Fixes #9010

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Mar 20, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.50%. Comparing base (d06ea4d) to head (62d51c3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9013      +/-   ##
==========================================
- Coverage   45.51%   45.50%   -0.01%     
==========================================
  Files        1275     1275              
  Lines       31208    31202       -6     
  Branches     3187     3184       -3     
==========================================
- Hits        14203    14199       -4     
+ Misses      16164    16163       -1     
+ Partials      841      840       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tommasini tommasini added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 20, 2024
@tommasini tommasini merged commit b181ae8 into main Mar 20, 2024
39 checks passed
@tommasini tommasini deleted the fix/9010-isEip1559compatible-migration29 branch March 20, 2024 21:33
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2024
@metamaskbot metamaskbot added the release-7.20.0 Issue or pull request that will be included in release 7.20.0 label Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.19.0 Issue or pull request that will be included in release 7.19.0 release-7.20.0 Issue or pull request that will be included in release 7.20.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Migration 29: Invalid NetworkController networkDetails isEIP1559Compatible: 'undefined'
4 participants