fix: Network not updating when changing account connected the first time on a DAPP

[tommasini]

Description

Updating the conditional case on BackgroundBridge onStateUpdate function to trigger notifyChainChanged, when the chainId changes and when the network changes, it will allow for both properties being sent when they are called more than once and they are miss matching. That was happening on the first switch of the network and causing the bug.

This fixes this issue: #9006

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

https://recordit.co/FEycCcnZ92

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[Cal-L]

Could you elaborate on how the network controller bump affected this logic?

[tommasini]

Yes, the NetworkController changed the logic on how the state was being updated on version 12, and that seems to be impacting how the dapp receive data, what's happening is that the dapp is receiving data with the networkId and chainId on different times, because the networkId at certain point in time is null when the network changes (Because it's still being fetched) and because of that was not updating on the first change.

On NetworkController V13 (Next Major version) the core repo will not expose the networkId in the network state, so where we need this networkId data we will need to fetch it
This how extension does it: https://github.com/MetaMask/metamask-extension/blob/4604c23100adf406aea764e19fa3087f5263bfdd/app/scripts/metamask-controller.js#L2773

[Cal-L]

LGTM

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: cc811ee
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5cac29cd-4ec8-4ac2-bfd8-e1c2d893144d

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request