chore: Consolidate and simplify isTest condition

[Cal-L]

Description

These changes both simplifies and consolidates the isTest condition, which is mainly used for automated testing

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 45.30%. Comparing base (543d671) to head (0056d45).

Files	Patch %	Lines
app/core/SDKConnect/utils/wait.util.ts	0.00%	1 Missing ⚠️
app/util/sentry/utils.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9038      +/-   ##
==========================================
- Coverage   45.55%   45.30%   -0.26%     
==========================================
  Files        1272     1272              
  Lines       31238    31238              
  Branches     3189     3189              
==========================================
- Hits        14232    14153      -79     
- Misses      16167    16245      +78     
- Partials      839      840       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 32b63ba
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9b22d851-22ca-4578-9560-f15e85a5d5fc

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2c9f8bc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/913578d8-2614-43bf-bf89-a03a005bae3c

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[cortisiko]

✅ ✅ ✅

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0056d45
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/407da45a-4694-4a9e-8373-bb025430ef22

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4da23e3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/67fa56da-7664-4d1e-989d-6c718b7331b0

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud