Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ramp): persist and format amount in build quote view #9039

Merged
merged 5 commits into from
Mar 27, 2024

Conversation

wachunei
Copy link
Member

Description

This PR makes the following changes:

  • It formats the amount input in the Buy flow during editing. Previously, the amount was formatted only after editing was completed.
  • It persists the amount input when the payment method is updated. Previously, the amount was cleared and reset to 0.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/RAMPS-1465

Manual testing steps

  1. Go to Buy/Sell flow
  2. Enter an amount: It must be formatted as it is being entered (only Buy flow)
  3. Finish the amount editing
  4. Switch payment method: The amount must not reset to 0

Screenshots/Recordings

Before

amount_before.mp4

After

amount_after.mp4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added the team-ramp issues related to Ramp features label Mar 22, 2024
@wachunei wachunei marked this pull request as ready for review March 25, 2024 14:04
@wachunei wachunei requested review from a team as code owners March 25, 2024 14:04
@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-ramp-qa Tickets that need feature QA on the ramps flows labels Mar 25, 2024
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 26, 2024
@wachunei wachunei added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 26, 2024
Copy link
Contributor

github-actions bot commented Mar 26, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 89fec7f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/46d437ab-b934-4562-8c72-4d07921cd521

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@bkirb
Copy link
Contributor

bkirb commented Mar 27, 2024

@wachunei LGTM I verified the buy and sell flows ✅

@wachunei wachunei added ramp-qa-passed and removed needs-ramp-qa Tickets that need feature QA on the ramps flows labels Mar 27, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.53%. Comparing base (18e2f11) to head (d48b8a0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9039      +/-   ##
==========================================
- Coverage   45.54%   45.53%   -0.01%     
==========================================
  Files        1272     1272              
  Lines       31236    31232       -4     
  Branches     3188     3187       -1     
==========================================
- Hits        14225    14221       -4     
  Misses      16171    16171              
  Partials      840      840              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 27, 2024

@wachunei wachunei merged commit e9a98d3 into main Mar 27, 2024
31 checks passed
@wachunei wachunei deleted the refactor/ramp-persist-format-build-quote-amount branch March 27, 2024 16:57
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2024
@metamaskbot metamaskbot added the release-7.20.0 Issue or pull request that will be included in release 7.20.0 label Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ramp-qa-passed release-7.20.0 Issue or pull request that will be included in release 7.20.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-ramp issues related to Ramp features
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants