Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ppom npm package to version 1.4.5 #9053

Merged
merged 4 commits into from
Mar 26, 2024
Merged

fix: update ppom npm package to version 1.4.5 #9053

merged 4 commits into from
Mar 26, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Mar 26, 2024

Description

Update PPOM npm package @blockaid/ppom-release to version 1.4.5.

Related issues

Fixes: #8994

Manual testing steps

  1. Enable blockaid
  2. Submit a malicious transaction in test dapp
  3. Blockaid validations should work as expected

Screenshots/Recordings

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 26, 2024
@jpuri jpuri requested review from a team as code owners March 26, 2024 04:54
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Mar 26, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4ca181d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ac324c45-fbf6-4c29-8041-c702bc289659

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.58%. Comparing base (c3646ff) to head (4ca181d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9053   +/-   ##
=======================================
  Coverage   45.58%   45.58%           
=======================================
  Files        1276     1276           
  Lines       31302    31302           
  Branches     3202     3202           
=======================================
+ Hits        14269    14270    +1     
+ Misses      16187    16186    -1     
  Partials      846      846           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

socket-security bot commented Mar 26, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/code-frame@7.24.2 environment 0 24.1 kB nicolo-ribaudo
npm/@babel/compat-data@7.22.20 None 0 64.1 kB nicolo-ribaudo
npm/@babel/helper-string-parser@7.24.1 None 0 31.7 kB nicolo-ribaudo
npm/@babel/highlight@7.24.2 environment 0 20.4 kB nicolo-ribaudo
npm/@babel/parser@7.24.1 None 0 1.88 MB nicolo-ribaudo
npm/@babel/preset-env@7.22.20 environment Transitive: filesystem, unsafe +14 6.03 MB nicolo-ribaudo
npm/@babel/template@7.24.0 None 0 68.9 kB nicolo-ribaudo
npm/@blockaid/ppom_release@1.4.5 network 0 3.32 MB blockaiduser
npm/@jridgewell/gen-mapping@0.3.5 None 0 81.6 kB jridgewell
npm/@jridgewell/set-array@1.2.1 None 0 17.9 kB jridgewell
npm/@jridgewell/trace-mapping@0.3.25 None 0 169 kB jridgewell
npm/@types/estree@1.0.2 None 0 25.7 kB types
npm/browserslist@4.23.0 environment, filesystem 0 62.8 kB ai
npm/caniuse-lite@1.0.30001600 None 0 2 MB caniuse-lite
npm/core-js-compat@3.32.2 None 0 686 kB zloirock
npm/electron-to-chromium@1.4.715 None 0 281 kB kilianvalkhof
npm/html-inline-script-webpack-plugin@3.2.1 None 0 25.1 kB icelam
npm/node-releases@2.0.14 None 0 34 kB chicoxyzzy
npm/resolve@1.22.6 environment, filesystem +2 200 kB ljharb

🚮 Removed packages: npm/@babel/preset-env@7.22.6, npm/@blockaid/ppom_release@1.2.8, npm/babel-loader@9.1.2, npm/html-inline-script-webpack-plugin@3.2.0, npm/webpack@5.88.1

View full report↗︎

Copy link

socket-security bot commented Mar 26, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/flat-cache@3.1.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@jpuri
Copy link
Contributor Author

jpuri commented Mar 26, 2024

@SocketSecurity ignore npm/flat-cache@3.1.0

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 26, 2024
Copy link
Contributor

github-actions bot commented Mar 26, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: cf70e9a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/537e7e28-9745-4bbd-9d25-3f41772c2256

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jpuri jpuri merged commit 8f8fe71 into main Mar 26, 2024
30 of 31 checks passed
@jpuri jpuri deleted the ppom_update_1.4.5 branch March 26, 2024 12:13
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2024
@metamaskbot metamaskbot added release-7.20.0 Issue or pull request that will be included in release 7.20.0 release-7.19.0 Issue or pull request that will be included in release 7.19.0 and removed release-7.20.0 Issue or pull request that will be included in release 7.20.0 labels Mar 26, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-7.19.0 on PR. Adding release label release-7.19.0 on PR and removing other release labels(release-7.20.0), as PR was cherry-picked in branch 7.19.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.19.0 Issue or pull request that will be included in release 7.19.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations-secure-ux-PR PR from the confirmations team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

PPOM - Update ppom dependency to 1.4.5
5 participants