Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: clean up detox build/run scripts #9069

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Conversation

cortisiko
Copy link
Member

Description

The purpose of this PR is to simplify the build and run commands for running tests locally.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. team-mobile-platform labels Mar 27, 2024
@cortisiko cortisiko self-assigned this Mar 27, 2024
@cortisiko cortisiko requested a review from a team as a code owner March 27, 2024 01:09
@cortisiko cortisiko requested a review from a team as a code owner March 27, 2024 01:12
@cortisiko cortisiko added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 27, 2024
Copy link
Contributor

github-actions bot commented Mar 27, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 653baf5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e6d37036-570c-4609-9d6e-62fc6fefa2ef

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.55%. Comparing base (7aaaf01) to head (a6d2604).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9069   +/-   ##
=======================================
  Coverage   45.55%   45.55%           
=======================================
  Files        1272     1272           
  Lines       31238    31238           
  Branches     3189     3189           
=======================================
  Hits        14232    14232           
  Misses      16167    16167           
  Partials      839      839           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bitrise.yml Outdated Show resolved Hide resolved
bitrise.yml Outdated Show resolved Hide resolved
docs/readme/testing.md Show resolved Hide resolved
docs/readme/testing.md Show resolved Hide resolved
package.json Show resolved Hide resolved
@cortisiko cortisiko added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 27, 2024
Copy link
Contributor

github-actions bot commented Mar 27, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a6d2604
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ecd06b9e-2747-4ea4-9bb8-9d5b86700d94

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko merged commit 543d671 into main Mar 28, 2024
35 checks passed
@cortisiko cortisiko deleted the detox/clean-up-build-script branch March 28, 2024 00:17
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2024
@metamaskbot metamaskbot added the release-7.20.0 Issue or pull request that will be included in release 7.20.0 label Mar 28, 2024
@leotm
Copy link
Contributor

leotm commented May 16, 2024

just realised we should update notion too, or could be better instead to refer to testing.md in Running tests > Locally section for less maintainance

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.20.0 Issue or pull request that will be included in release 7.20.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants