fix: check for preferences controller in 036 migration

[owencraston]

Description

1. What is the reason for the change?

• @Cal-L discovered a missing test case in his PR for my migration. In order to perfectly handle the edge cases for this migration we must also check if the Preferences controller state is defined.
• In order to unblock the above PR we need to handle this edge case.

2. What is the improvement/solution?

• check if the preferences controller state is defined
• add tests for the error cases and error messages

Related issues

Fixes: N/A

Manual testing steps

• the tests should all pass.
• this migration was already tested and QAd in this previous PR

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[tommasini]

LGTM!!

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.55%. Comparing base (853fde0) to head (403e84b).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9080      +/-   ##
==========================================
+ Coverage   45.53%   45.55%   +0.02%     
==========================================
  Files        1272     1272              
  Lines       31232    31235       +3     
  Branches     3187     3188       +1     
==========================================
+ Hits        14220    14230      +10     
+ Misses      16172    16167       -5     
+ Partials      840      838       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Cal-L]

LGTM