Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ramp): add deeplink handler #9153

Merged
merged 10 commits into from
Apr 23, 2024
Merged

feat(ramp): add deeplink handler #9153

merged 10 commits into from
Apr 23, 2024

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Apr 5, 2024 •
edited

Description

This PR:

  • Adds /buy and /sell deeplinks actions (in addition to previous /buy-crypto and /sell-crypto). This means metamask://buy, metamask://sell, https://metamask.app.link/buy and https://metamask.app.link/sell will be handled by the deeplink manager.
  • Adds a new handleRampUrl handler: This will help ramp team to handle more complex URLs. For example /buy?chainId=1&token=0x4946fcea7c692606e8908002e55a582af44ac121)

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/RAMPS-1510

Manual testing steps

New links should open the buy or sell feature:

Existing functionality must not have changed.

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features needs-ramp-qa Tickets that need feature QA on the ramps flows Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 5, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0b83b43
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/93f6d2b4-30e8-49db-9774-213e4027ef4e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@wachunei wachunei removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Apr 5, 2024
@wachunei wachunei marked this pull request as ready for review April 5, 2024 20:01
@wachunei wachunei requested review from a team as code owners April 5, 2024 20:01
@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 9, 2024
@wachunei wachunei added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 15, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 91a79b1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d6cf2265-a9de-4b3e-990f-fd1755c08ba8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@bkirb
Copy link
Contributor

bkirb commented Apr 18, 2024

LGTM for QA ✅ I verified the new and existing deeplinks

@wachunei wachunei removed the needs-ramp-qa Tickets that need feature QA on the ramps flows label Apr 19, 2024
@wachunei wachunei added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 19, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3917eaa
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b20a56dc-f203-4bc3-ad63-e9eb8992e11d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@wachunei wachunei added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b437bb2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1f1cb42b-54c7-4bf3-ba36-2d4529aa9a9d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Gudahtt
Copy link
Member

Gudahtt commented Apr 22, 2024 •
edited

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b437bb2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e387fc81-e067-4e36-9618-3497f2522691

We are investigating this Bitrise error (it's caused by #9345).

Please refrain from updating this branch until further notice.

We want to retry the failure here until we can establish whether it's caused by a bad cache or not.

This has been retried, and we have confirmed that the error is caused by a bad cache entry

@Gudahtt Gudahtt mentioned this pull request Apr 22, 2024
Closed
@wachunei wachunei added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5de1023
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0a924d69-5a91-4cf9-8502-478efb58d7bf

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@wachunei wachunei merged commit c58d46a into main Apr 23, 2024
31 checks passed
@wachunei wachunei deleted the feature/ramp-deeplink-handler branch April 23, 2024 13:54
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
@gauthierpetetin gauthierpetetin added release-7.22.0 Issue or pull request that will be included in release 7.22.0 and removed release-7.28.0 labels Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@georgeweiler georgeweiler georgeweiler approved these changes

Assignees
No one assigned
Labels
release-7.22.0 Issue or pull request that will be included in release 7.22.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-ramp issues related to Ramp features
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wachunei @bkirb @Gudahtt @georgeweiler @gauthierpetetin @metamaskbot