Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: signature controller update to v6.0.0 #9166

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

MarioAslau
Copy link
Contributor

@MarioAslau MarioAslau commented Apr 8, 2024

Description

Updated Signature Controller to version 6.0.0.
Removed keyringController property from constructor in Engine.ts

e2e Tests: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1539b3e5-c224-4987-9b1f-62e479c4de19

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/1613

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Recording.6.mp4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Apr 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Apr 8, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/signature-controller@6.0.0 None +14 679 kB metamaskbot

🚮 Removed packages: npm/@metamask/signature-controller@5.3.1

View full report↗︎

@MarioAslau MarioAslau self-assigned this Apr 8, 2024
@MarioAslau MarioAslau marked this pull request as ready for review April 8, 2024 16:34
@MarioAslau MarioAslau requested a review from a team as a code owner April 8, 2024 16:34
@MarioAslau MarioAslau added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 8, 2024
Copy link
Contributor

github-actions bot commented Apr 8, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 11a1e26
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/72608ed1-3686-4cd4-84f2-d88f6495daf7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MarioAslau MarioAslau removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 8, 2024
@tommasini tommasini changed the title feat: signature controller update to v600 feat: signature controller update to v6.0.0 Apr 8, 2024
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MarioAslau MarioAslau merged commit f4ef3c1 into main Apr 9, 2024
37 checks passed
@MarioAslau MarioAslau deleted the feat/update-singatureController-v600 branch April 9, 2024 14:58
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2024
@metamaskbot metamaskbot added the release-7.21.0 Issue or pull request that will be included in release 7.21.0 label Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.21.0 Issue or pull request that will be included in release 7.21.0 team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants