-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: signature controller update to v6.0.0 #9166
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/signature-controller@5.3.1 |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Updated Signature Controller to version 6.0.0.
Removed keyringController property from constructor in Engine.ts
e2e Tests: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1539b3e5-c224-4987-9b1f-62e479c4de19
Related issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/1613
Manual testing steps
Screenshots/Recordings
Before
After
Recording.6.mp4
Pre-merge author checklist
Pre-merge reviewer checklist