Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix rpc test on Ci for Android #9181

Merged
merged 12 commits into from
Apr 10, 2024
Merged

test: fix rpc test on Ci for Android #9181

merged 12 commits into from
Apr 10, 2024

Conversation

Andepande
Copy link
Member

Description

  • We're getting test failures on Ci when running regression for Android, this PR fixes the issue by disabling Detox Synchronization for Android on some steps.

Related issues

Fixes:
https://app.zenhub.com/workspaces/metamask-mobile-platform-5f984938ddc0e4001d4b79cb/issues/gh/metamask/metamask-mobile/9050

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Andepande Andepande added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. E2E Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 9, 2024
@Andepande Andepande requested a review from a team as a code owner April 9, 2024 19:31
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f810a81
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8a9ef9b1-e252-4315-8242-99b2ed2e8d55

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Andepande Andepande added team-mobile-platform and removed No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. E2E labels Apr 9, 2024
@gauthierpetetin gauthierpetetin added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 9, 2024
@Andepande Andepande added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 10, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b0ce977
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2f5d136b-3e96-42e6-8810-f1db57be1f47

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Andepande Andepande mentioned this pull request Apr 10, 2024
Closed
SamuelSalas
SamuelSalas approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@SamuelSalas SamuelSalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Andepande Andepande merged commit 08e1eba into main Apr 10, 2024
31 checks passed
@Andepande Andepande deleted the test-9050-failing-test-fix-RPC branch April 10, 2024 23:30
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
@metamaskbot metamaskbot added the release-7.21.0 Issue or pull request that will be included in release 7.21.0 label Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SamuelSalas SamuelSalas SamuelSalas approved these changes

@tommasini tommasini tommasini approved these changes

Assignees
No one assigned
Labels
release-7.21.0 Issue or pull request that will be included in release 7.21.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Andepande @SamuelSalas @tommasini @gauthierpetetin @metamaskbot