feat: gas fee controller update v^7 #9183

tommasini · 2024-04-10T00:10:14Z

Description

Gas fee controller updated to version ^7

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/1623

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…o delete networkId property from the network controller state and added a network id property to our own internal property, created the reducer and the action for that property and added the dispatch to the engine event subscriber, update the patch of network controller, updated test cases and initial states with new data structure with the networkId property

…only look for network id when the network did change

…ion we do not need to ensure was being called with the right argument, we have separate unit tests for that function

…etworkProvider that will contain our internal property regarding a network provider, updated on the migrations files, backgroundBridge and related components, the test files were updated accordingly as well. On Engine file was added a subscribe of the networkWillChange event to make sure we have the networkId property reseted if the intention of switching starts

… want to investigate any issue, this is the better approach to not polute Sentry and save it for the investigations

… to fetch network id

…ageProvider with the property networkId, updated files with the new property inpageProvider, deleting old actions and reducers files about networkProvider, addressed review on unit tests, changed initial root state and fixture builder initial state with the inpageProvider, and updated respective migrations 033 and 037 with reviews and new property, updated also engine file imports with the action of the slice of inpageprovider

… fresh install the networkId would not be updated because the event network did change did not trigger

github-actions · 2024-04-12T09:54:42Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a91e54a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7985eafc-b829-4614-b70f-5c536dc57cfd

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-04-12T15:31:50Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: afe52bd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/00069865-5e55-4338-9c7c-6a22c898a825

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-04-15T11:52:17Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2c40643
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8422848b-9623-45fb-a62f-706ad20c7816

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

codecov-commenter · 2024-04-15T12:03:52Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.57%. Comparing base (f7466da) to head (2c40643).
Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9183      +/-   ##
==========================================
- Coverage   45.58%   45.57%   -0.01%     
==========================================
  Files        1289     1289              
  Lines       31973    31951      -22     
  Branches     3314     3314              
==========================================
- Hits        14574    14562      -12     
+ Misses      16528    16518      -10     
  Partials      871      871

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-04-15T19:18:21Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 432021f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7b05a740-9c37-4ac9-af8f-f6813d7c974c

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

tommasini · 2024-04-15T19:56:32Z

E2E is failling due to flakiness, here is a screen shot of the personal sign working:

sonarcloud · 2024-04-15T21:03:39Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

github-actions · 2024-04-15T21:06:46Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0bf1cc1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/057e73d0-e09f-4149-8058-77f69c3de08b

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Cal-L

Lgtm

tommasini and others added 30 commits March 26, 2024 19:31

remove unusable import

22887ba

Merge branch 'main' into feat/1629-update-network-controller-v13-0-1

e2b926e

Changed from subscribe network state change to network did change to …

b9ae3c4

…only look for network id when the network did change

added js doc and unit tests for deprecatedGetNetworkId

6210b09

fix new unit test, since we are not spying the convertNetworkId funct…

6f53c81

…ion we do not need to ensure was being called with the right argument, we have separate unit tests for that function

remove unnecessary async and unnecessary check

2f9622f

return loading if networkId is undefined on backgroundBridge

d2c8dc9

merge main and solve migrations conflicts

d3decf6

address bug on the new action and reducer of networkProvider

9df5483

replace sentry capture exception for the Logger error since we do not…

bb6b1ff

… want to investigate any issue, this is the better approach to not polute Sentry and save it for the investigations

change Logger error to console error on engine file catch when trying…

e2e71bc

… to fetch network id

update test name

21ef7c5

merge main and solve lock file conflicts

c10d981

address ts issues

19c8ccf

merge main and solve conflicts

01c34ae

Merge branch 'main' into feat/1629-update-network-controller-v13-0-1

cd6f0b5

fix fixture-builder type

8537709

merge main and solve conflicts

60e62ac

re add comment

4a36f97

remove unnecessary ts expect error comment

60c3c48

Merge branch 'main' into feat/1629-update-network-controller-v13-0-1

0f6b255

Merge branch 'main' into feat/1629-update-network-controller-v13-0-1

1db2228

Merge branch 'main' into feat/1629-update-network-controller-v13-0-1

8294f70

Merge branch 'main' into feat/1629-update-network-controller-v13-0-1

eb5f0c0

change subscribe of network id to network state change event since on…

6ed2efa

… fresh install the networkId would not be updated because the event network did change did not trigger

Merge branch 'main' into feat/1629-update-network-controller-v13-0-1

1c840b5

Update gas fee controller to v^7

4c26c1e

merge main and solve yarn lock conflicts

afe52bd

tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 12, 2024

Merge branch 'main' into feat/1623-gas-fee-controller-v7

2c40643

tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 15, 2024

Merge branch 'main' into feat/1623-gas-fee-controller-v7

432021f

Cal-L added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 15, 2024

chrisleewilcox added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 15, 2024

merge main and solve conflicts

0bf1cc1

Cal-L added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 15, 2024

Cal-L approved these changes Apr 15, 2024

View reviewed changes

tommasini merged commit 9001b0f into main Apr 15, 2024
35 checks passed

tommasini deleted the feat/1623-gas-fee-controller-v7 branch April 15, 2024 21:58

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 15, 2024

github-actions bot locked and limited conversation to collaborators Apr 15, 2024

metamaskbot added the release-7.22.0 Issue or pull request that will be included in release 7.22.0 label Apr 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: gas fee controller update v^7 #9183

feat: gas fee controller update v^7 #9183

tommasini commented Apr 10, 2024 •

edited

github-actions bot commented Apr 12, 2024 •

edited by metamaskbot

github-actions bot commented Apr 12, 2024 •

edited by metamaskbot

github-actions bot commented Apr 15, 2024 •

edited by metamaskbot

codecov-commenter commented Apr 15, 2024

github-actions bot commented Apr 15, 2024 •

edited by metamaskbot

tommasini commented Apr 15, 2024

sonarcloud bot commented Apr 15, 2024

github-actions bot commented Apr 15, 2024 •

edited by metamaskbot

Cal-L left a comment

feat: gas fee controller update v^7 #9183

feat: gas fee controller update v^7 #9183

Conversation

tommasini commented Apr 10, 2024 • edited

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Apr 12, 2024 • edited by metamaskbot

Bitrise

github-actions bot commented Apr 12, 2024 • edited by metamaskbot

Bitrise

github-actions bot commented Apr 15, 2024 • edited by metamaskbot

Bitrise

codecov-commenter commented Apr 15, 2024

Codecov Report

github-actions bot commented Apr 15, 2024 • edited by metamaskbot

Bitrise

tommasini commented Apr 15, 2024

sonarcloud bot commented Apr 15, 2024

Quality Gate passed

github-actions bot commented Apr 15, 2024 • edited by metamaskbot

Bitrise

Cal-L left a comment

Choose a reason for hiding this comment

tommasini commented Apr 10, 2024 •

edited

github-actions bot commented Apr 12, 2024 •

edited by metamaskbot

github-actions bot commented Apr 12, 2024 •

edited by metamaskbot

github-actions bot commented Apr 15, 2024 •

edited by metamaskbot

github-actions bot commented Apr 15, 2024 •

edited by metamaskbot

github-actions bot commented Apr 15, 2024 •

edited by metamaskbot