Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wc fixes + ux improvements #9188

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Conversation

abretonc7s
Copy link
Contributor

@abretonc7s abretonc7s commented Apr 10, 2024

Description

  • Update we-sdk to fix missing chainId on cold start
  • Fix: "return to dapp" modal not displayed on new session proposal after disconnect

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sentry-io bot commented Apr 10, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: app/components/Nav/App/index.js

Function Unhandled Issue
App Error: TaskQueue: Error with task : The 'navigation' object hasn't been initialized yet. This might happ... (app/component-library/comp...
Event Count: 2 Affected Users: 2

Did you find this useful? React with a 👍 or 👎

@abretonc7s abretonc7s self-assigned this Apr 10, 2024
Copy link

socket-security bot commented Apr 10, 2024

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@walletconnect/se-sdk@1.7.1

View full report↗︎

@abretonc7s abretonc7s added needs-qa Any New Features that needs a full manual QA prior to being added to a release. team-sdk SDK team WalletConnect WalletConnect related issue or bug labels Apr 10, 2024
@abretonc7s abretonc7s marked this pull request as ready for review April 10, 2024 11:19
@abretonc7s abretonc7s requested a review from a team as a code owner April 10, 2024 11:19
Copy link

sonarcloud bot commented Apr 10, 2024

Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherferreira9 christopherferreira9 added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 10, 2024
@christopherferreira9
Copy link
Contributor

Test Cases for both android and iOS:

Connect to a WC Dapp via deeplink

Sign -> You're able to sign

Connect to a WC Dapp via deeplink with 2 accounts

Switch account on the wallet to permittedAccounts[1]

Wallet get's synced and you're able to sign

Repeat both test cases but using a QRCode instead.

@christopherferreira9 christopherferreira9 added QA Passed A successful QA run through has been done Run Smoke E2E Triggers smoke e2e on Bitrise and removed QA in Progress QA has started on the feature. labels Apr 10, 2024
Copy link
Contributor

github-actions bot commented Apr 10, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4982624
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7d23bbe3-cc8c-48b4-bbf7-be67edfe232c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@christopherferreira9 christopherferreira9 merged commit f1d8274 into main Apr 10, 2024
40 of 41 checks passed
@christopherferreira9 christopherferreira9 deleted the feat/wc-ui-fixes branch April 10, 2024 13:24
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
@metamaskbot metamaskbot added the release-7.21.0 Issue or pull request that will be included in release 7.21.0 label Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-7.21.0 Issue or pull request that will be included in release 7.21.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-sdk SDK team WalletConnect WalletConnect related issue or bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants