Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Change instances of messages to enContent while importing from locales #9197

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

SamuelSalas
Copy link
Member

Description

We want to improve the variable name we use while importing from the locales folder. "Messages" is a bit unclear and can cause confusion. The purpose here is to rename to "enContent".

Related issues

Fixes: 1510

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@SamuelSalas SamuelSalas self-assigned this Apr 10, 2024
@SamuelSalas SamuelSalas requested a review from a team as a code owner April 10, 2024 17:49
@metamaskbot metamaskbot added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 10, 2024
Copy link

sonarcloud bot commented Apr 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.95%. Comparing base (d1d5c00) to head (eae0fba).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9197      +/-   ##
==========================================
- Coverage   45.98%   45.95%   -0.04%     
==========================================
  Files        1273     1277       +4     
  Lines       31342    31538     +196     
  Branches     3213     3248      +35     
==========================================
+ Hits        14414    14493      +79     
- Misses      16079    16190     +111     
- Partials      849      855       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Andepande Andepande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@SamuelSalas SamuelSalas merged commit 2a56fd7 into main Apr 11, 2024
31 checks passed
@SamuelSalas SamuelSalas deleted the test/1510-rename-messages-instances branch April 11, 2024 14:11
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 11, 2024
@metamaskbot metamaskbot added the release-7.21.0 Issue or pull request that will be included in release 7.21.0 label Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.21.0 Issue or pull request that will be included in release 7.21.0 team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants