Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: translate multi import tokens #9205

Merged
merged 2 commits into from
Apr 11, 2024
Merged

feat: translate multi import tokens #9205

merged 2 commits into from
Apr 11, 2024

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Apr 11, 2024

Description

translate for multi import tokens feature

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb added area-translation For Blendin translation. team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Apr 11, 2024
@salimtb salimtb requested a review from a team as a code owner April 11, 2024 14:59
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

NicolasMassart
NicolasMassart previously approved these changes Apr 11, 2024
View reviewed changes
@salimtb salimtb force-pushed the translate-multi-import-tokens branch from 1d9cc8e to 726635e Compare April 11, 2024 15:19
@salimtb salimtb force-pushed the translate-multi-import-tokens branch from a853365 to af03a80 Compare April 11, 2024 15:26
@salimtb salimtb added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 11, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: af03a80
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e6d8d510-fcce-49c9-bab0-8011b76f2545

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Cal-L
Cal-L approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@salimtb salimtb merged commit 50a3c2c into main Apr 11, 2024
33 checks passed
@salimtb salimtb deleted the translate-multi-import-tokens branch April 11, 2024 16:21
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2024
@metamaskbot metamaskbot added the release-7.21.0 Issue or pull request that will be included in release 7.21.0 label Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

@NicolasMassart NicolasMassart NicolasMassart left review comments

Assignees
No one assigned
Labels
area-translation For Blendin translation. needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.21.0 Issue or pull request that will be included in release 7.21.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@salimtb @NicolasMassart @Cal-L @metamaskbot