Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cherry-pick #9092 #9217

Merged
merged 1 commit into from
Apr 12, 2024
Merged

chore: cherry-pick #9092 #9217

merged 1 commit into from
Apr 12, 2024

Conversation

github-actions[bot]
Copy link
Contributor

This PR cherry-picks #9092

@gantunesr @metamaskbot
fix: check HD keyring (#9092)
ccb453d 
Adds a patch solution to prevent the HD keyring being removed from the `@metamask/eth-keyring-controller` state.
@sethkfman sethkfman marked this pull request as ready for review April 12, 2024 13:35
@sethkfman sethkfman requested a review from a team as a code owner April 12, 2024 13:35
@sethkfman sethkfman added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 12, 2024
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Apr 12, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ccb453d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7e17cc84-5f13-47ef-bce9-56af96c997ed

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sethkfman
sethkfman approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman merged commit f071532 into release/7.21.0 Apr 12, 2024
6 checks passed
@sethkfman sethkfman deleted the chore/cherry-pick-9092 branch April 12, 2024 14:18
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
@metamaskbot metamaskbot added the release-7.21.0 Issue or pull request that will be included in release 7.21.0 label Apr 12, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-7.21.0 on PR, as PR was cherry-picked in branch 7.21.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
release-7.21.0 Issue or pull request that will be included in release 7.21.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-accounts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@metamaskbot @sethkfman @gantunesr