-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve the URL validation and error handling in 'parseDeeplink' Method #9236
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise❌❌❌ Commit hash: 3e149cc Note
|
Quality Gate passedIssues Measures |
All good in QA.
|
Bitrise✅✅✅ Commit hash: 7ba1ec1 Note
|
Description
*This is a fix to this Issue: https://github.com/MetaMask/mobile-planning/issues/1520
This pull request enhances the
parseDeeplink
method by adding robust URL validation and error handling.Key improvements include:
URL Validation
: Ensures only correctly formatted URLs are processed to prevent errors during deep linking.Error Handling
: Captures exceptions with updated error handling, and alerting users to invalid URLs via areact-native
alert.These updates aim to improve the security and user experience by preventing the processing of malformed URLs and providing immediate feedback on errors.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
Available in this Issue:
https://github.com/MetaMask/mobile-planning/issues/1520
After
Screen.Recording.2024-04-15.at.11.14.37.mov
Pre-merge author checklist
Pre-merge reviewer checklist