Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: notifications types - [4 of 10] #9240

Merged
merged 14 commits into from
Apr 19, 2024
Merged

Conversation

Jonathansoufer
Copy link
Contributor

@Jonathansoufer Jonathansoufer commented Apr 15, 2024

Description

This PR implements all types needed for the notifications feature. Most of these types will be (later on) be moved to a central place where all clients (extension, portfolio, and mobile) could use it. Now we have been replicating them on clients Portfolio being the first one

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 15, 2024
Copy link

socket-security bot commented Apr 15, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/contentful@10.8.7 environment, eval, filesystem, network +9 2.46 MB contentful-ecosystem

View full report↗︎

Copy link

socket-security bot commented Apr 15, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/contentful@10.8.7

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment

app/util/notifications/types/userStorage/index.ts Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@Jonathansoufer Jonathansoufer removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 17, 2024
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

app/util/notifications/types/userStorage/index.ts Outdated Show resolved Hide resolved
app/util/notifications/types/userStorage/index.ts Outdated Show resolved Hide resolved
@Cal-L
Copy link
Contributor

Cal-L commented Apr 18, 2024

You can mark contentful as safe for socket security by commenting @SocketSecurity ignore npm/contentful@10.8.7

@Jonathansoufer
Copy link
Contributor Author

Jonathansoufer commented Apr 18, 2024

@SocketSecurity ignore npm/contentful@10.8.7

@Cal-L Cal-L added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 18, 2024
Copy link
Contributor

github-actions bot commented Apr 18, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b67caff
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f94ee571-8670-40b1-b0fc-56b1d7042d95

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Apr 18, 2024

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. E2E failures doesn't seem related to this PR

@Jonathansoufer Jonathansoufer merged commit d380062 into main Apr 19, 2024
30 of 31 checks passed
@Jonathansoufer Jonathansoufer deleted the feat/notifications-types branch April 19, 2024 08:38
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2024
@metamaskbot metamaskbot added the release-7.22.0 Issue or pull request that will be included in release 7.22.0 label Apr 19, 2024
@Jonathansoufer Jonathansoufer changed the title feat: notifications types feat: notifications types - [4 of 8] May 8, 2024
@Jonathansoufer Jonathansoufer changed the title feat: notifications types - [4 of 8] feat: notifications types - [4 of 10] May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.22.0 Issue or pull request that will be included in release 7.22.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform team-notifications Notifications team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants