Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): replace eth-json-rpc-errors with eth-rpc-errors #9253

Merged
merged 2 commits into from
Apr 16, 2024
Merged

fix(deps): replace eth-json-rpc-errors with eth-rpc-errors #9253

merged 2 commits into from
Apr 16, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Apr 16, 2024 •
edited

Description

eth-json-rpc-errors was renamed to eth-rpc-errors in 2020.

metamask-mobile is still pulling in both packages. This removes deprecated eth-json-rpc-errors and replaces references with eth-rpc-errors.

Related issues

Manual testing steps

Screenshots/Recordings

Before

n/a

After

n/a

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-security labels Apr 16, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Apr 16, 2024 •
edited

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/eth-json-rpc-errors@2.0.2

View full report↗︎

@legobeat legobeat requested review from leotm and Mrtenz April 16, 2024 05:35
@legobeat legobeat force-pushed the deps-eth-json-rpc-errors branch 2 times, most recently from 74e2976 to 3113b1a Compare April 16, 2024 09:28
@Mrtenz
Copy link
Member

Mrtenz commented Apr 16, 2024

eth-rpc-errors was later renamed to @metamask/rpc-errors. Should we replace it with that, or does that cause issues?

@legobeat
Copy link
Contributor Author

legobeat commented Apr 16, 2024 •
edited

eth-rpc-errors was later renamed to @metamask/rpc-errors. Should we replace it with that, or does that cause issues?

Indeed that would be a next step, but one thing at a time?

This already requires some intervention: https://github.com/MetaMask/metamask-mobile/actions/runs/8703247441/job/23869119234?pr=9253

@legobeat legobeat marked this pull request as ready for review April 16, 2024 10:12
@legobeat legobeat requested a review from a team as a code owner April 16, 2024 10:12
@legobeat legobeat mentioned this pull request Apr 16, 2024
Closed
7 tasks
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@legobeat legobeat merged commit 0ea89bf into main Apr 16, 2024
31 checks passed
@legobeat legobeat deleted the deps-eth-json-rpc-errors branch April 16, 2024 12:15
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
@metamaskbot metamaskbot added the release-7.22.0 Issue or pull request that will be included in release 7.22.0 label Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leotm leotm leotm approved these changes

@Mrtenz Mrtenz Awaiting requested review from Mrtenz

@mcmire mcmire Awaiting requested review from mcmire

@NicolasMassart NicolasMassart Awaiting requested review from NicolasMassart

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file release-7.22.0 Issue or pull request that will be included in release 7.22.0 team-security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@legobeat @Mrtenz @leotm @metamaskbot