Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): axios@1.6.0->^1.6.8 #9278

Merged
merged 1 commit into from
Apr 23, 2024
Merged

fix(deps): axios@1.6.0->^1.6.8 #9278

merged 1 commit into from
Apr 23, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Apr 17, 2024 •
edited

Description

The package axios has since previously been globally hard-pinned via resolutions at 1.6.0.

This upgrades to 1.6.8 and indicates semver by changing resolution version to ^1.6.8.

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security Socket Security
Copy link

socket-security bot commented Apr 17, 2024 •
edited

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/axios@1.6.8 network +1 1.87 MB jasonsaayman

🚮 Removed packages: npm/axios@1.6.0

View full report↗︎

@legobeat legobeat added dependencies Pull requests that update a dependency file team-security labels Apr 17, 2024
@legobeat legobeat marked this pull request as ready for review April 17, 2024 08:07
@legobeat legobeat requested a review from a team as a code owner April 17, 2024 08:07
@legobeat legobeat force-pushed the deps-axios branch 2 times, most recently from bf4aa90 to 0f9194f Compare April 18, 2024 08:50
@legobeat legobeat added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 18, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0f9194f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7f560d57-3b61-4c1e-9300-34ec1ef60e03

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat force-pushed the deps-axios branch 3 times, most recently from ccb5e94 to adaf1fe Compare April 18, 2024 20:07
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 19, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: abe2a40
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c8de1c6b-9da5-4e26-834e-2b03707512ff

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 19, 2024
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 19, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 84e0e71
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6bb6182b-c96f-408d-8c26-3cc62988d093

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat force-pushed the deps-axios branch 2 times, most recently from 48ea597 to 28bd8ef Compare April 22, 2024 23:33
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 28bd8ef
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f49a3ea3-d39f-4264-aa81-0ff71950d934

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sethkfman
sethkfman approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@legobeat legobeat merged commit e42c796 into main Apr 23, 2024
30 of 31 checks passed
@legobeat legobeat deleted the deps-axios branch April 23, 2024 20:33
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
@gauthierpetetin gauthierpetetin added release-7.22.0 Issue or pull request that will be included in release 7.22.0 and removed release-7.28.0 labels Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

@NicolasMassart NicolasMassart Awaiting requested review from NicolasMassart

@NicholasEllul NicholasEllul Awaiting requested review from NicholasEllul

@tommasini tommasini Awaiting requested review from tommasini

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file release-7.22.0 Issue or pull request that will be included in release 7.22.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-security
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@legobeat @sethkfman @gauthierpetetin @metamaskbot