Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add strings to en.json for smart transactions #9320

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Apr 18, 2024

Description

This PR adds a number of strings to en.json for Smart Transactions, which will come out in a separate PR. I've split the much larger PR into smaller pieces to improve reviewer experience and readability.

Related issues

The much larger PR these changes have been picked from: #9315

Fixes: n/a

Manual testing steps

n/a

Screenshots/Recordings

Before

n/a

After

n/a

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Apr 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@gauthierpetetin gauthierpetetin added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 22, 2024
@infiniteflower infiniteflower merged commit 87309d1 into main Apr 22, 2024
48 checks passed
@infiniteflower infiniteflower deleted the feat/smart-tx-small-translations branch April 22, 2024 20:46
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 22, 2024
@gauthierpetetin gauthierpetetin added release-7.22.0 Issue or pull request that will be included in release 7.22.0 and removed release-7.28.0 labels Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.22.0 Issue or pull request that will be included in release 7.22.0 team-swaps
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants