Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): move @metamask/react-native-splash-screen from github.com to registry #9327

Merged
merged 1 commit into from
Apr 23, 2024
Merged

fix(deps): move @metamask/react-native-splash-screen from github.com to registry #9327

merged 1 commit into from
Apr 23, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Apr 19, 2024 •
edited

Description

This replaces react-native-splash-screen dependency from git+https://github.com with published @metamask/react-native-splash-screen fork. The contents are equivalent.

Related issues

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-security labels Apr 19, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Apr 19, 2024 •
edited

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/react-native-splash-screen@3.2.0 None 0 39 kB gudahtt

🚮 Removed packages: npm/react-native-splash-screen@3.2.0

View full report↗︎

@legobeat legobeat added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 19, 2024
@legobeat legobeat marked this pull request as ready for review April 19, 2024 03:03
@legobeat legobeat requested a review from a team as a code owner April 19, 2024 03:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 19, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: fdcec8e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4583496f-0741-455b-b6af-ceef5df7c033

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 19, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: db3488e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bc397846-35db-4ef0-9e75-fbb7c725179c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat force-pushed the fix-git-dep-react-native-splash-screen branch from db3488e to 5d2d947 Compare April 19, 2024 20:23
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 19, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5d2d947
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/747aac7a-0da5-4dd6-9090-940b87cb537d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@gauthierpetetin gauthierpetetin added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 22, 2024
tommasini
tommasini approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Please before merge, re run the E2E, they should pass after merge main

@legobeat legobeat force-pushed the fix-git-dep-react-native-splash-screen branch from 5d2d947 to e2aaf87 Compare April 22, 2024 22:17
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e2aaf87
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b52d77bc-fb7a-4b35-95f0-ad3b85300164

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat force-pushed the fix-git-dep-react-native-splash-screen branch from e2aaf87 to 6c7ae0b Compare April 22, 2024 23:21
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6c7ae0b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/12a49f58-7ce9-4eff-8579-d4dbe7c03abc

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 22, 2024
@legobeat legobeat force-pushed the fix-git-dep-react-native-splash-screen branch from 6c7ae0b to bc433ce Compare April 22, 2024 23:49
@legobeat legobeat added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: bc433ce
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d9104319-ebc6-4c4e-8af2-b325fcb15ce9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@legobeat legobeat merged commit fd6c0e2 into main Apr 23, 2024
33 checks passed
@legobeat legobeat deleted the fix-git-dep-react-native-splash-screen branch April 23, 2024 07:22
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 23, 2024
@gauthierpetetin gauthierpetetin added release-7.22.0 Issue or pull request that will be included in release 7.22.0 and removed release-7.28.0 labels Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

@andrepimenta andrepimenta Awaiting requested review from andrepimenta

@rickycodes rickycodes Awaiting requested review from rickycodes

@NicolasMassart NicolasMassart Awaiting requested review from NicolasMassart

@leotm leotm Awaiting requested review from leotm

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file release-7.22.0 Issue or pull request that will be included in release 7.22.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-security
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@legobeat @tommasini @gauthierpetetin @metamaskbot