Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added log to capture failing exception for getItem #9329

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

MarioAslau
Copy link
Contributor

@MarioAslau MarioAslau commented Apr 19, 2024

Description

As part of the Vault Corruption Tactics: https://www.notion.so/metamask-consensys/Vault-Corruption-98cdfc486e75419fa3e53b7bfe244060

We have to increase our logging around possible areas that could be leading to Vault Corruption, to gather more information.

  • add Sentry logs to capture exceptions in MigratedStorage when getItem() fail
  • logging keys as well in error message, in order to give us more information when debugging

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@MarioAslau MarioAslau self-assigned this Apr 19, 2024
@MarioAslau MarioAslau added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform labels Apr 19, 2024
@MarioAslau MarioAslau marked this pull request as ready for review April 19, 2024 10:28
@MarioAslau MarioAslau requested a review from a team as a code owner April 19, 2024 10:28
Copy link

sonarcloud bot commented Apr 19, 2024

@MarioAslau MarioAslau merged commit 0922dd2 into main Apr 19, 2024
31 checks passed
@MarioAslau MarioAslau deleted the feat/add-log-migratedStorage-exception branch April 19, 2024 16:44
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 19, 2024
@metamaskbot metamaskbot added release-7.22.0 Issue or pull request that will be included in release 7.22.0 release-7.21.0 Issue or pull request that will be included in release 7.21.0 and removed release-7.22.0 Issue or pull request that will be included in release 7.22.0 labels Apr 19, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-7.21.0 on PR. Adding release label release-7.21.0 on PR and removing other release labels(release-7.22.0), as PR was cherry-picked in branch 7.21.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.21.0 Issue or pull request that will be included in release 7.21.0 team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants