Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pin web3-provider-engine@^16.0.8 in resolutions #9338

Merged
merged 2 commits into from
Apr 22, 2024
Merged

fix: pin web3-provider-engine@^16.0.8 in resolutions #9338

merged 2 commits into from
Apr 22, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Apr 22, 2024 •
edited

Description

Deprecated web3-provider-engine is still used transitively by @metamask/swaps-controller. This updates the version to 16.0.8 (latest being 17.0.1), updating dependencies with bug- and security fixes.

Related issues

Manual testing steps

  1. Perform a swap

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security Socket Security
Copy link

socket-security bot commented Apr 22, 2024 •
edited

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@cypress/request@3.0.1, npm/eth-json-rpc-middleware@8.1.0, npm/http-signature@1.3.6

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Contributor Author 

@SocketSecurity ignore npm/@cypress/request@3.0.1
@SocketSecurity ignore npm/eth-json-rpc-middleware@8.1.0

network access ok

@legobeat
Copy link
Contributor Author 

@SocketSecurity ignore npm/http-signature@1.3.6

new author ok

@legobeat legobeat added dependencies Pull requests that update a dependency file team-security labels Apr 22, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Apr 22, 2024 •
edited

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/sshpk@1.18.0 Transitive: environment, filesystem +7 612 kB bahamat
npm/web3-provider-engine@16.0.8 Transitive: environment, eval, filesystem, network +46 5.93 MB lgbot

View full report↗︎

@legobeat legobeat marked this pull request as ready for review April 22, 2024 10:34
@legobeat legobeat requested a review from a team as a code owner April 22, 2024 10:34
@gauthierpetetin gauthierpetetin added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 22, 2024
@tommasini
Copy link
Contributor

tommasini commented Apr 22, 2024 •
edited

Can we run the E2E tests? Please merge main into it first

@legobeat legobeat added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f235d38
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9e4a1d50-76e6-4708-9948-1214b89e6b3b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d0c5c3a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/66ff1cba-fff1-4ade-9503-2266b94e59d4

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@legobeat
Copy link
Contributor Author

Can we run the E2E tests? Please merge main into it first

Rebased and bitrise passing.

@legobeat legobeat requested a review from tommasini April 22, 2024 23:22
@legobeat legobeat merged commit dea12c9 into main Apr 22, 2024
37 checks passed
@legobeat legobeat deleted the deps-web3-provider-engine branch April 22, 2024 23:46
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 22, 2024
@gauthierpetetin gauthierpetetin added release-7.22.0 Issue or pull request that will be included in release 7.22.0 and removed release-7.28.0 labels Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file release-7.22.0 Issue or pull request that will be included in release 7.22.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-security
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@legobeat @tommasini @gauthierpetetin @metamaskbot