Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unusable import variables #9360

Merged
merged 1 commit into from
Apr 22, 2024
Merged

fix: remove unusable import variables #9360

merged 1 commit into from
Apr 22, 2024

Conversation

tommasini
Copy link
Contributor

Description

Remove unusable variable to unblock github CI

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform labels Apr 22, 2024
@tommasini tommasini requested a review from a team as a code owner April 22, 2024 20:28
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

chrisleewilcox
chrisleewilcox approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@tommasini tommasini merged commit 169a341 into main Apr 22, 2024
37 checks passed
@tommasini tommasini deleted the fix/lint-issue-main branch April 22, 2024 20:42
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 22, 2024
@gauthierpetetin gauthierpetetin added release-7.22.0 Issue or pull request that will be included in release 7.22.0 and removed release-7.28.0 labels Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bergeron bergeron bergeron approved these changes

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

Assignees
No one assigned
Labels
release-7.22.0 Issue or pull request that will be included in release 7.22.0 team-mobile-platform
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tommasini @bergeron @chrisleewilcox @gauthierpetetin @metamaskbot