Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(translations): Crowdin does not allow slashes #9362

Merged
merged 4 commits into from
Apr 23, 2024
Merged

fix(translations): Crowdin does not allow slashes #9362

merged 4 commits into from
Apr 23, 2024

Conversation

desi
Copy link
Contributor

@desi desi commented Apr 22, 2024 •
edited

Description

Related issues

Fixes:

Manual testing steps

  1. Manually tested using the crowdin-sandbox repo.
  2. Full testing is happening for the whole flow in mobile now. All manual testing being done by Desi

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@desi
Crowdin does not allow slashes
f540f7e 
 - The crowdin cli does not allow slashes in crowdin branch names
 - Have altered the branch names as they exist on crowdin and
 - made it such that it will work on the github side and the crowdin
 - side.
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@desi desi added No E2E Smoke Needed If the PR does not need E2E smoke test run release-7.19.1 Issue or pull request that will be included in release 7.19.1 team-wallet-framework labels Apr 22, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 22, 2024
@desi desi changed the title Crowdin does not allow slashes fix(translations): Crowdin does not allow slashes Apr 22, 2024
@desi desi marked this pull request as ready for review April 22, 2024 22:43
@desi desi requested a review from a team as a code owner April 22, 2024 22:43
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sethkfman
sethkfman approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@desi desi merged commit ab3c9a7 into main Apr 23, 2024
31 checks passed
@desi desi deleted the fix/dm-handle-branch-names-with-slashes branch April 23, 2024 13:13
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
@gauthierpetetin gauthierpetetin added release-7.22.0 Issue or pull request that will be included in release 7.22.0 and removed release-7.28.0 labels Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template No E2E Smoke Needed If the PR does not need E2E smoke test run release-7.19.1 Issue or pull request that will be included in release 7.19.1 release-7.22.0 Issue or pull request that will be included in release 7.22.0 team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@desi @sethkfman @gauthierpetetin @metamaskbot