Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(translations): Fix hard coded repo name left from testing in diff repo #9395

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

desi
Copy link
Contributor

@desi desi commented Apr 24, 2024

Description

Testing is being done via another repo and I accidentally brought over a hard coded url from that repo. :(

Related issues

Fixes:

Manual testing steps

  1. Manual tested in other repo

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@desi desi added No E2E Smoke Needed If the PR does not need E2E smoke test run release-7.19.0 Issue or pull request that will be included in release 7.19.0 team-wallet-framework labels Apr 24, 2024
Copy link

sonarcloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@desi desi marked this pull request as ready for review April 24, 2024 22:10
@desi desi requested a review from a team as a code owner April 24, 2024 22:10
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@desi desi merged commit 840169d into main Apr 24, 2024
48 checks passed
@desi desi deleted the fix/dm-fix-hardcoded-repo branch April 24, 2024 22:39
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
@metamaskbot metamaskbot added the release-7.22.0 Issue or pull request that will be included in release 7.22.0 label Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run release-7.19.0 Issue or pull request that will be included in release 7.19.0 release-7.22.0 Issue or pull request that will be included in release 7.22.0 team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants