test: fix flakey E2E tests

[cortisiko]

Description

The purpose of this PR is to stabilize the e2e tests on main. What was done in this PR:

• Detox environment setup time and tear down time was increased

  • Why? Detox was attempting to execute tests prior to the simulator/emulator booting up. This caused the tests to fail with the error: Exceeded timeout of 30000ms while tearing down Detox environment or Exceeded timeout of 25000ms while setting up Detox environment

• There was a duplicate device.launchapp() step in the before hook for the NFT import test. This caused the test to double launch, perhaps a symptom of why the test is unstable.

• The swap-regression test was flaking on Android as well. The app would fetch quotes when swapping ERC20 <> ETH during the test running, which introduced instability. We should follow up in a separate task to address this.

• Sign tests in the confirmations folder were also unstable. Each sign spec file contains the following tests: one to sign a transaction and the other to cancel it. Each test used fixtures to set up the app in a specific state. However, this resulted in some instability in the confirmation signature tests. Specifically, a few tests attempted to use a fixture port that was already in use, leading to errors. This needs to be investigated further in a follow-up task. Lastly, The time it takes to run the signature tests was too lengthy.

  • I condense the test actions into one it block, which makes the tests run quicker and more stable.

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Passing Smoke tests:
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0572909c-97af-40f3-addf-8a2b02da1cf2
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f6f1f081-4707-41bc-8c1a-955c6b2a6163
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ae68f7f2-34b9-47fa-a31e-47be939ea3ef

Passing regression:
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/46fe763c-1c62-401f-a6b8-b0b86484ce39

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e0cef75
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f6f1f081-4707-41bc-8c1a-955c6b2a6163

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[MarioAslau]

LGTM !

[chrisleewilcox]

LGTM