Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade permission-controller to 8.0.0 #9527

Merged
merged 6 commits into from
May 9, 2024
Merged

fix: upgrade permission-controller to 8.0.0 #9527

merged 6 commits into from
May 9, 2024

Conversation

frankvonhoven
Copy link
Contributor

@frankvonhoven frankvonhoven commented May 3, 2024 •
edited

Description

Upgrades the permission-controller from 7.1.0 --> 8.0.0

Related issues

Fixes: 1695

Manual testing steps

  • Connect to app
    • Single account
    • Multiple accounts
  • With multiple connected accounts
    • Disconnect Account
      • Next connected account should be selected
  • Open a new tab

Recordings

Connect Dapp Single Account

conect-dapp-single-acct.mp4

Connect Dapp Multiple Accounts

connect-dapp-multiple.mp4

TestDapp Connect Account

test-dapp-connect-account.mp4

TestDapp Connect/Disconnnect/GET Account

test-dapp-connect-disconnect-get.mp4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@frankvonhoven frankvonhoven added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform labels May 3, 2024
@frankvonhoven frankvonhoven requested a review from a team as a code owner May 3, 2024 15:39
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 3, 2024
legobeat
legobeat reviewed May 4, 2024
View reviewed changes
ios/Podfile.lock Outdated Show resolved Hide resolved
@legobeat legobeat added the Run Smoke E2E Triggers smoke e2e on Bitrise label May 4, 2024
@legobeat legobeat mentioned this pull request May 4, 2024
Merged
7 tasks
legobeat
legobeat reviewed May 5, 2024
View reviewed changes
yarn.lock Show resolved Hide resolved
@legobeat legobeat requested a review from a team May 5, 2024 13:44
@legobeat
Copy link
Contributor

legobeat commented May 6, 2024

LGTM!

(Needs a rebase on main to resolve the conflicting yarn.lock, though)

@socket-security Socket Security
Copy link

socket-security bot commented May 7, 2024 •
edited

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@frankvonhoven frankvonhoven added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b1b0dd8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5a2c9fcf-37df-4bd8-8a26-ce6d217b9fbd

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

tommasini
tommasini approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frankvonhoven frankvonhoven merged commit d0b4c36 into main May 9, 2024
33 checks passed
@frankvonhoven frankvonhoven deleted the fix/1695-upgrade-permission-controller branch May 9, 2024 19:24
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 9, 2024
@metamaskbot metamaskbot added the release-7.23.0 Issue or pull request that will be included in release 7.23.0 label May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L left review comments

@legobeat legobeat legobeat left review comments

@tommasini tommasini tommasini approved these changes

Assignees
No one assigned
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-7.23.0 Issue or pull request that will be included in release 7.23.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@frankvonhoven @legobeat @Cal-L @tommasini @metamaskbot