feat: OS to Reservoir migration

[sahar-fehri]

Description

This PR adds patches to mobile to enable Open Sea (OS) migration.

Related issues

MMASSETS-156. (Restricted access Jira issue)

Main core PR: MetaMask/core#4030
Core Compare link used to create the assets patch: https://github.com/MetaMask/core/compare/patch/mobile-assets-controllers-v-18-0-0...patch/mobile-assets-controllers-v-18-0-0-os-migration-v2?expand=1

Context

Problem: We want to roll out Reservoir to Extension and Mobile similar to how we have done in Portfolio.
Requirements:
Define a way to compare OpenSea’s spam filtering and Reservoir’s spam filtering. Ideally the spam filtering is similar.
Create Core PR to migrate calls from OS to Reservoir.
Create PR on mobile to migrate from OS to Reservoir.
Create Extension PR to migrate from OS to Reservoir
Define roll out plan for Extension and Mobile
Roll out Reservoir to Extension and Mobile

Today, to get the NFTs core is calling opensea V2 api to fetch user nfts and to add new nfts (get NFT metadata)
In this ticket we wanted to call Reservoir API instead of calling openseaV2.
We are not changing any of the functional behaviors of the app, we are just swapping third party providers.
So the app should behave the exact same regarding any NFT related functionality:
Like showing NFT details when clicking on the NFT
And being able to remove/add the NFT
Mark it as favorite
Sending NFts

Manual testing steps

1. Go to the NFT tab
2. You should see your NFTs
3. Adding/removing NFTs should still work as expected
4. clicking on the NFT and seeing the NFT details should work as expected.

Screenshots/Recordings

The NFT tab should behave the same. You should be able to see the same NFTs you had.

Only thing noticed while testing is for some collections you might see either a different image or the mobile default image (if the new third party provider was not able to return the image)

Before

Screen.Recording.2024-05-08.at.00.15.48.mov

Screen.Recording.2024-05-08.at.01.38.49.mov

After

Screen.Recording.2024-05-07.at.23.44.39.mov

Screen.Recording.2024-05-08.at.00.08.08.mov

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 52d7aeb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9bc2efd0-3271-4b9c-8cf2-0a359f56a128

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[tommasini]

Hey @sahar-fehri this PR looks good to me, but can we have a recording with the nft auto detect and custom import to have a history of how it was the functionality now? It's good as well to record playing around with the IPFS Gateway Enabled and Display Nft Media privacy toggles to make sure the privacy features

[sahar-fehri]

Hey @sahar-fehri this PR looks good to me, but can we have a recording with the nft auto detect and custom import to have a history of how it was the functionality now? It's good as well to record playing around with the IPFS Gateway Enabled and Display Nft Media privacy toggles to make sure the privacy features

Thanks @tommasini 🙏 i added videos to the description!
You might notice that after the migration some collection logos might look different. This is because the new third party provider is returning sometimes the nft image and not the collection image. I think this is not a blocker to the rollout and we can check this with them.

[tommasini]

LGTM!