Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix/9345 bitrise cache failure #9611

Merged
merged 16 commits into from
May 10, 2024
Merged

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented May 10, 2024

Description

As suggested by the Bitrise team, the changes in the PR replaces both the save and restore step with deploy and pull, which shares intermediate files within pipelines instead of caching on a global level. An extra step added post pull step was to copy the pulled files into the directories that Detox uses to find the builds. Lastly, a small update was made to the brew install ccache command to include the flag HOMEBREW_NO_DEPENDENTS_CHECK=1, which should skip updating packages that depend onccache, therefore speeding up the step.

Related issues

Fixes: #9345

Manual testing steps

  • Run pr_smoke_e2e_pipeline and ensure that both iOS and Android are building and testing successfully
  • Smoke test will be run on this PR

Screenshots/Recordings

N/A

Before

N/A

After

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested a review from a team as a code owner May 10, 2024 19:30
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels May 10, 2024
@Cal-L Cal-L added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 10, 2024
Copy link
Contributor

github-actions bot commented May 10, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5eef9c3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c02e5604-b4a4-4bd7-80f1-0d27806149a6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 🙏

Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Cal-L Cal-L merged commit 2648bb6 into main May 10, 2024
43 checks passed
@Cal-L Cal-L deleted the fix/9345-bitrise-cache-failure branch May 10, 2024 20:38
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2024
@metamaskbot metamaskbot added the release-7.24.0 Issue or pull request that will be included in release 7.24.0 label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.24.0 Issue or pull request that will be included in release 7.24.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Intermittent "Restore cache build" failure
3 participants