Retry ethereum.enable after 1 sec if bridge not ready #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunobar79
added
android
estebanmino
approved these changes
Jul 30, 2019
|
QA Passed 👍 |
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* retry ethereum.enable after 1 sec * fix approval screen info * update snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For light pages that were calling ethereum.enable right after the onload event was triggered, they might get an error if the react native bridge is not ready.
This PR simply retries that request.
The reproduction site that was failing is now working: https://brunobar79.github.io/dapp-issues-repro/