Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade react-native-svg to 15.3 #9658

Merged
merged 2 commits into from
May 20, 2024
Merged

chore: Upgrade react-native-svg to 15.3 #9658

merged 2 commits into from
May 20, 2024

Conversation

kylanhurt
Copy link
Contributor

@kylanhurt kylanhurt commented May 16, 2024

Description

Related issues

Fixes: https://github.com/orgs/MetaMask/projects/60/views/6?pane=issue&itemId=61547905

Manual testing steps

  1. Go to https://app.poolside.party with the in-app browser and connect the wallet
  2. Once you connect, you would see an Root Error: Text strings must be rendered within a <Text> component. error message, but now you should not see that error message... the wallet should connect just fine.

Screenshots/Recordings

Before

connect-error.mov

After

connect-error-fixed.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented May 16, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/react-native-svg@15.3.0 network +1 2.97 MB jake7

🚮 Removed packages: npm/react-native-svg@15.2.0

View full report↗︎

@kylanhurt kylanhurt marked this pull request as ready for review May 16, 2024 23:31
@kylanhurt kylanhurt requested a review from a team as a code owner May 16, 2024 23:31
@kylanhurt kylanhurt added team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels May 16, 2024
Copy link
Contributor

github-actions bot commented May 16, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0714662
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/17cec348-8ce2-4080-a687-34bcab226cd7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat requested a review from a team May 17, 2024 01:09
@kylanhurt kylanhurt changed the title Upgrade react-native-svg to 15.3 chore: Upgrade react-native-svg to 15.3 May 17, 2024
@kylanhurt kylanhurt added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 17, 2024
Copy link
Contributor

github-actions bot commented May 17, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3465de6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/45f8521f-76c8-4cc4-ae3a-ed7c6f4a0e76

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Re-run yarn setup to undo iOS change

Revert "Upgrade react-native-svg to 15.3"

This reverts commit 0714662.

Upgrade react-native-svg
Copy link

socket-security bot commented May 20, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/react-native-svg@15.3.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@kylanhurt kylanhurt added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 20, 2024
Copy link
Contributor

github-actions bot commented May 20, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7ef31c8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/866c5556-8f38-4a6f-a09a-757944682851

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@kylanhurt
Copy link
Contributor Author

@SocketSecurity ignore npm/react-native-svg@15.3.0

Latest contributor appears to be part of the organization that maintains the GitHub repo and npm package. Also contributor to other React Native projects

Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legobeat legobeat requested a review from a team May 20, 2024 17:20
@kylanhurt kylanhurt merged commit 11ff42e into main May 20, 2024
35 checks passed
@kylanhurt kylanhurt deleted the kylan/svg branch May 20, 2024 17:34
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2024
@metamaskbot metamaskbot added the release-7.24.0 Issue or pull request that will be included in release 7.24.0 label May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.24.0 Issue or pull request that will be included in release 7.24.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants