-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade react-native-svg to 15.3 #9658
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/react-native-svg@15.2.0 |
|
|
Re-run yarn setup to undo iOS change Revert "Upgrade react-native-svg to 15.3" This reverts commit 0714662. Upgrade react-native-svg
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
|
|
@SocketSecurity ignore npm/react-native-svg@15.3.0 Latest contributor appears to be part of the organization that maintains the GitHub repo and npm package. Also contributor to other React Native projects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Related issues
Fixes: https://github.com/orgs/MetaMask/projects/60/views/6?pane=issue&itemId=61547905
Manual testing steps
Root Error: Text strings must be rendered within a <Text> component.
error message, but now you should not see that error message... the wallet should connect just fine.Screenshots/Recordings
Before
connect-error.mov
After
connect-error-fixed.mov
Pre-merge author checklist
Pre-merge reviewer checklist